Repository navigation
Conversation
This was referenced Oct 23, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: efdebb4 | Previous: 0ea05f6 | Ratio |
|---|---|---|---|
peak memory |
1659.801 MB |
1699.445 MB |
0.98 |
peak threads |
368 threads |
357 threads |
1.03 |
network (transport) |
2730.001 MB |
2725.914 MB |
1.00 |
disk write |
2.129 MB |
1.469 MB |
1.45 |
instructions |
121.086 G |
136.571 G |
0.89 |
This comment was automatically generated by workflow using github-action-benchmark.
TomCC7
changed the base branch from
cc/fix/cdr-pointcloud-record-helpers
to
cc/refactor/cdr-sensor-value-helpers
October 26, 2026 19:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A float-second time index cannot retain adjacent nanosecond samples at epoch timestamps. Introduce a bounded index for generated TransformStamped values keyed by integer source nanoseconds. Retain independent snapshots and prune relative to the newest stored stamp so late arrivals cannot keep obsolete samples alive.
This PR isolates the timestamp index and its regressions. #4734 binds it to the migrated Python TF consumer. Frame search/composition and existing nearest-sample query behavior remain separate; this is not a tf2 tree/interpolation implementation.
Validation: 3 isolated regressions pass for adjacent nanoseconds and snapshot ownership, out-of-order eviction, and negative time. Tests import the buffer directly and do not depend on migrated TF transports.
Base: #4800. Extracted from #4734 so the implementation and its tests can be reviewed separately from consumer renames.
Domain helper API update
The three isolated TF buffer tests pass against the consolidated utility layer.
All helper callers in this layer use the consolidated API. The final stack passes syntax, Ruff lint and format checks for 239 changed Python files. Branch history is preserved through normal merge updates.
The dedicated
.github/workflows/cdr-native.ymlis removed throughout this stack. Test sources remain; CDR integration CI will be designed separately.