Repository navigation
Conversation
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 086c166 | Previous: ecc2b8f | Ratio |
|---|---|---|---|
peak memory |
1591.996 MB |
1570.996 MB |
1.01 |
peak threads |
353 threads |
355 threads |
0.99 |
network (transport) |
2722.111 MB |
2730.387 MB |
1.00 |
disk write |
1.52 MB |
1.496 MB |
1.02 |
instructions |
115.235 G |
115 G |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cc/feat/cdr-message-packages #4721 +/- ##
================================================================
- Coverage 82.33% 82.33% -0.01%
================================================================
Files 1677 1678 +1
Lines 156940 157004 +64
Branches 13161 13166 +5
================================================================
+ Hits 129220 129266 +46
- Misses 24048 24075 +27
+ Partials 3672 3663 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
[Medium impact] No merge-blocking issue was identified. The installed external message flow passed provider registration, CDR roundtrip, and built-in type identity checks. SummaryAdds a standalone external message project that reuses the built-in
TomCC7 explicitly documents that these examples require the matching review DimOS wheel; that requirement is intentional. No actionable issues were found. No merge-blocking issue was identified in the reviewed changes. Reviews (1) · Last reviewed commit: "Merge branch 'cc/review/cdr-preserve-leg..." · Reviewed by Greptile |
5032b12 to
085d09d
Compare
0446dd3 to
67c50a0
Compare
67c50a0 to
086c166
Compare
What this adds
Install an external
.msgproject as a Python package. Its cdrgen provider registers the generated types alongside built-in messages.Base: #4366. This layer adds external message authoring and registration; it does not add another code generator or transport SDK.
How to test
From this PR's checkout, with
uvand a C++ compiler:No previous PR installation is needed. The example checks provider registration, shared Header identity and decoded DeviceReading values. Reinstall the external package and restart Python after changing definitions.
Full instructions. WIP: application integration follows in later layers.
CDR dependencies and TF conventions
The stack consumes published dimos-cdrgen 0.1.2 and the immutable CDR library fix. SDK #4774 now uses standard ROS
TFMessage,TransformStampedand integerTime, with no per-driver TF codec callbacks or parallel public transform type. The externaltransformslibrary, validated by its complete std/no_std/serde and ARM verification gate, owns the frame tree, common-time lookup, interpolation and static history. Its atomic batch patch is pinned to5ae9563de0c02638c04e393aadfad28444a4398e.Combined-stack local validation: SDK 121, macros 22, mapper 101, MLS 135, local planner 91, follower 63, V4L2 6 and depth2depth 12 Rust tests; all 24 native/DimSim/port-contract acceptance tests pass without skips. The mapper exchange includes Python CDR
tf_staticinput; the follower exchange covers drive, arrival, a new goal and empty-path stop. Missing native binaries fail the dedicated job. RealSense passescargo check --all-targets --features docs-only; device linking and hardware execution were not tested. Seven real source-staging layouts pass locked Cargo resolution. Native acceptance for tipcc463c163aed465f7c1d6808165bf640820b0182: workflow run. These are combined-tip results, with the SDK additionally tested standalone at its own layer.Native Nix inputs use verified source archive
f7723ad4d5b9aa5dfe63614b6b537d1ccc2d212e, SHA256f90af8fa794a34d53ee9481c6d0bdb63138853b30f851d92960fd34224ff62b2. Full Nix builds remain unverified. SDK static edges persist after receipt; LCM/Zenoh do not acquire DDS transient-local durability from CDR. Existing Python mount publishers retain dynamictfcompatibility. Legacy modules remain explicitly pinned to SDK 0.1.0.Stack #4776 preserves existing history and PR bases. Current main still has conflicts with the original stack; this change does not rebase onto main. No DimOS PR has been merged.