Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: 12c81e0 | Previous: ecc2b8f | Ratio |
|---|---|---|---|
peak memory |
1588.184 MB |
1570.996 MB |
1.01 |
peak threads |
347 threads |
355 threads |
0.98 |
network (transport) |
2724.766 MB |
2730.387 MB |
1.00 |
disk write |
1.742 MB |
1.496 MB |
1.16 |
instructions |
115.685 G |
115 G |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
This was referenced Oct 20, 2026
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This was referenced Oct 20, 2026
TomCC7
added this pull request to stack #4743
October 20, 2026 22:26
TomCC7
force-pushed
the
cc/feat/cdr-unit-recording
branch
from
October 21, 2026 02:08
59b492b to
3ce7f4e
Compare
TomCC7
commented
Oct 21, 2026
TomCC7
left a comment
Member
Author
There was a problem hiding this comment.
need to think about an example used in this pr
Member
Author
There was a problem hiding this comment.
verify that we do need this and can't be solved by rust's own cdr lib
TomCC7
removed this pull request from stack #4743
October 22, 2026 18:51
TomCC7
changed the base branch from
cc/feat/cdr-unit-transports
to
cc/fix/cdr-native-sdk
October 22, 2026 18:52
TomCC7
added this pull request to stack #4776
October 22, 2026 18:52
TomCC7
removed this pull request from stack #4776
October 23, 2026 08:47
TomCC7
changed the base branch from
cc/fix/cdr-native-sdk
to
cc/feat/cdr-unit-transports
October 23, 2026 08:47
TomCC7
added this pull request to stack #4799
October 23, 2026 08:47
TomCC7
removed this pull request from stack #4799
October 23, 2026 09:19
TomCC7
added this pull request to stack #4804
October 23, 2026 09:19
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
ros2msgschemas in MCAP and mark channels ascdr.CdrMcapStore.Base: #4774 (shared native SDK), after #4722. Recording uses reception time; the original
header.stampstays in the payload.How to test
From this PR's checkout, with Linux,
uv, Rust and the native build dependencies:Wait for recorder readiness, record for about 15 seconds, then press Ctrl+C once. Open the saved
artifact_pathin Foxglove and viewposein framemap. It should move in a circle. No robot, ROS installation or API key is needed.Prerequisites, expected output and Python readback.
WIP: local installation, recording and Python readback were checked. Foxglove UI rendering and Nix were not verified. Business blueprint migration, compression and default cutover remain later work.
Shared CDR foundation
Standard ROS definitions are fetched and verified through the existing source lock and generation pipeline in #4366. Native SDK support is included in #4722. Shared Python value implementations and regressions are reviewed in #4800–#4803 before the #4734 caller migration. SDK and consumers use the same generated Rust message crate, including
Time,TransformStampedandTFMessage; there is no separate TF schema package or generation command. Camera/depth callers migrate in #4734 and mapping/navigation callers in #4737.The external CDR and transforms library pins remain unchanged. Local verification passed 122 SDK tests, all existing native consumer suites, and all 24 real native/DimSim/port acceptance tests without skips. Seven staged Nix source layouts resolve exactly one message crate with locked Cargo metadata. This is not a full Nix build or hardware validation. Fresh CI runs verify #4722 independently and the combined stack tip.
Stack #4804 contains the 12 original feature PRs and four separately reviewed adapter/buffer PRs (#4800–#4803). The redundant #4774 is superseded by #4722. No feature PR has been merged into main; existing conflicts with main and the WIP cutover failures in #4739 remain.