Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
go2 replay realtime (arm64)
Details
| Benchmark suite | Current: deecf9a | Previous: ecc2b8f | Ratio |
|---|---|---|---|
peak memory |
1602.242 MB |
1570.996 MB |
1.02 |
peak threads |
357 threads |
355 threads |
1.01 |
network (transport) |
2722.06 MB |
2730.387 MB |
1.00 |
disk write |
1.719 MB |
1.496 MB |
1.15 |
instructions |
115.629 G |
115 G |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This was referenced Oct 20, 2026
This was referenced Oct 20, 2026
TomCC7
added this pull request to stack #4743
October 20, 2026 22:26
TomCC7
commented
Oct 21, 2026
TomCC7
force-pushed
the
cc/feat/cdr-unit-transports
branch
from
October 21, 2026 01:05
254cb8b to
2b46518
Compare
TomCC7
requested review from
Dreamsorcerer,
aclauer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
October 21, 2026 02:03
TomCC7
commented
Oct 21, 2026
Contributor
[Medium impact] No outstanding findings block merging this PR. SummaryThis PR shares message codecs across LCM, Zenoh, and WebRTC. Generated messages use CDR; legacy messages keep their LCM format.
Reviews (2) · Last reviewed commit: "fix(transport): preserve native DDS type..." · Reviewed by Greptile |
Member
Author
|
@greptile review |
TomCC7
force-pushed
the
cc/feat/cdr-unit-transports
branch
from
October 21, 2026 04:39
23a3480 to
42b9f1f
Compare
TomCC7
force-pushed
the
cc/feat/cdr-unit-transports
branch
from
October 21, 2026 18:43
42b9f1f to
deecf9a
Compare
TomCC7
removed this pull request from stack #4743
October 22, 2026 18:51
TomCC7
added this pull request to stack #4776
October 22, 2026 18:52
TomCC7
removed this pull request from stack #4776
October 23, 2026 08:47
TomCC7
added this pull request to stack #4799
October 23, 2026 08:47
TomCC7
removed this pull request from stack #4799
October 23, 2026 09:19
TomCC7
added this pull request to stack #4804
October 23, 2026 09:19
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind CDR and legacy codecs from the declared message type in existing LCM, Zenoh and WebRTC transports. Native SDK output callbacks return encoding errors instead of panicking, and the SDK uses the external CDR library for complete messages.
The SDK consumes the same generated ROS messages as its callers. Remove custom public TF types and handwritten TF storage/query algorithms. The external transforms library owns tree storage, interpolation and common-time lookup; standard
TFMessagestreams bindtfandtf_static. SDK time and geometry adapters preserve integer ROS timestamps. The backend pins each child's parent and static/dynamic kind. LCM/Zenoh do not implement DDS transient-local durability; existing Python mount publishers still use dynamic tf for compatibility.Base: #4721. The SDK changes previously separated into #4774 are included here because they are part of this unmerged transport feature. Business callers migrate in their original feature PRs. The CI workflow at this layer runs SDK/macros checks against this layer's sources; full consumer interoperability checks are added at the stack tip.
Shared CDR foundation
Standard ROS definitions are fetched and verified through the existing source lock and generation pipeline in #4366. Native SDK support is included in #4722. Shared Python value implementations and regressions are reviewed in #4800–#4803 before the #4734 caller migration. SDK and consumers use the same generated Rust message crate, including
Time,TransformStampedandTFMessage; there is no separate TF schema package or generation command. Camera/depth callers migrate in #4734 and mapping/navigation callers in #4737.The external CDR and transforms library pins remain unchanged. Local verification passed 122 SDK tests, all existing native consumer suites, and all 24 real native/DimSim/port acceptance tests without skips. Seven staged Nix source layouts resolve exactly one message crate with locked Cargo metadata. This is not a full Nix build or hardware validation. Fresh CI runs verify #4722 independently and the combined stack tip.
Stack #4804 contains the 12 original feature PRs and four separately reviewed adapter/buffer PRs (#4800–#4803). The redundant #4774 is superseded by #4722. No feature PR has been merged into main; existing conflicts with main and the WIP cutover failures in #4739 remain.