Repository navigation
Conversation
This was referenced Oct 22, 2026
This was referenced Oct 22, 2026
TomCC7
changed the title
This was referenced Oct 22, 2026
TomCC7
commented
Oct 23, 2026
Member
Author
There was a problem hiding this comment.
completely wrong location, cheeck pre stack on msg definition. also aren't this upstream? do we need custom def?
TomCC7
removed this pull request from stack #4776
October 23, 2026 08:47
TomCC7
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #4722, which now includes the native SDK changes as part of the original unmerged transport feature. Stack #4799 links the 12 original feature PRs directly; #4732 now builds on #4722.
The duplicate standard TF schema package and separate generation command have been deleted. The SDK and native consumers depend on the same Rust messages generated from the upstream definitions already locked in #4366. No custom ROS TF definitions are needed.
This PR is closed to remove the redundant review layer. Its discussion is retained, including the source-ownership correction that prompted the change.