Repository navigation
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #4366 +/- ##
==========================================
- Coverage 82.37% 82.33% -0.04%
==========================================
Files 1674 1677 +3
Lines 156721 156940 +219
Branches 13144 13161 +17
==========================================
+ Hits 129101 129220 +119
- Misses 23965 24048 +83
- Partials 3655 3672 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes 🚀 New features to boost your workflow:
|
TomCC7
marked this pull request as ready for review
October 21, 2026 00:17
TomCC7
requested review from
Dreamsorcerer,
aclauer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
October 21, 2026 00:17
Contributor
[Medium impact] The change reaches DimOS installs and message-package builders. The confirmed problems affect maintainer generation and native packaging workflows and are non-blocking; neither establishes a security vulnerability. FindingsSummaryAdds built-in CDR messages under
The two maintainer-workflow issues do not block merging. Reviews (1) · Last reviewed commit: "docs(messages): document complete built-..." · Reviewed by Greptile |
paul-nechifor
previously approved these changes
Oct 21, 2026
paul-nechifor
previously approved these changes
Oct 21, 2026
TomCC7
force-pushed
the
cc/feat/cdr-message-packages
branch
from
October 21, 2026 04:39
9e0d7b3 to
0f3c1f6
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
.msgdefinitions with cdrgen during package installation.dimos.messages, plus schemas and native source artifacts.dimos.msgsand business code unchanged.Flow: definitions → cdrgen → installed artifacts → runnable examples. Base:
main.How to test
From this PR's checkout, with
uvand a C++ compiler:uv venv .venv-msg-review --python 3.12 DIMOS_ALLOW_MISSING_COCKPIT=1 uv pip install --python .venv-msg-review/bin/python . .venv-msg-review/bin/python -I examples/message-package/demo_installed_wheel.pyThe example prints the generated message and schema directories and checks CDR round trips.
For Python → C++ → Rust → Python, install CMake and Rust/Cargo, then run:
uv pip install --python .venv-msg-review/bin/python 'dimos-cdrgen[native]==0.1.2' .venv-msg-review/bin/python -I examples/message-package/demo_native.pyThe native example checks
map/cpp/rustand the unchanged Header timestamp. Full instructions.DIMOS_ALLOW_MISSING_COCKPIT=1permits installation without prebuilt web assets. The Rust relay uses the complete external CDR library directly, pinned to the tested library fix in TomCC7/cdr-rs#1. WIP: transport, SDK and business integration follow in later PRs.CDR dependencies and TF conventions
The stack consumes published dimos-cdrgen 0.1.2 and the immutable CDR library fix. SDK #4774 now uses standard ROS
TFMessage,TransformStampedand integerTime, with no per-driver TF codec callbacks or parallel public transform type. The externaltransformslibrary, validated by its complete std/no_std/serde and ARM verification gate, owns the frame tree, common-time lookup, interpolation and static history. Its atomic batch patch is pinned to5ae9563de0c02638c04e393aadfad28444a4398e.Combined-stack local validation: SDK 121, macros 22, mapper 101, MLS 135, local planner 91, follower 63, V4L2 6 and depth2depth 12 Rust tests; all 24 native/DimSim/port-contract acceptance tests pass without skips. The mapper exchange includes Python CDR
tf_staticinput; the follower exchange covers drive, arrival, a new goal and empty-path stop. Missing native binaries fail the dedicated job. RealSense passescargo check --all-targets --features docs-only; device linking and hardware execution were not tested. Seven real source-staging layouts pass locked Cargo resolution. Native acceptance for tipcc463c163aed465f7c1d6808165bf640820b0182: workflow run. These are combined-tip results, with the SDK additionally tested standalone at its own layer.Native Nix inputs use verified source archive
f7723ad4d5b9aa5dfe63614b6b537d1ccc2d212e, SHA256f90af8fa794a34d53ee9481c6d0bdb63138853b30f851d92960fd34224ff62b2. Full Nix builds remain unverified. SDK static edges persist after receipt; LCM/Zenoh do not acquire DDS transient-local durability from CDR. Existing Python mount publishers retain dynamictfcompatibility. Legacy modules remain explicitly pinned to SDK 0.1.0.Stack #4776 preserves existing history and PR bases. Current main still has conflicts with the original stack; this change does not rebase onto main. No DimOS PR has been merged.