Repository navigation
Conversation
A rejected multi-transform message must not leave earlier inserts or retention evictions behind. Stage the batch in private registry storage and commit only after every insertion succeeds, without exposing a public registry Clone implementation. Assisted-by: Codex:gpt-6.1-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rejected multi-transform message can leave earlier insertions or retention evictions behind. Add
Registry::add_transformsto stage a batch in private registry storage and commit it only when every insertion succeeds. No publicCloneimplementation or dependency is added.DimOS needs this when applying one standard ROS TFMessage to its shared frame tree: dimensionalOS/dimos#4774 . An invalid packet must not partially update the graph. The operation needs sealed history and topology, so callers cannot implement rollback through the existing public API. Staging currently copies retained history.
The regression rejects a cyclic batch after an insertion would evict an older sample, then checks that the original sample and topology survive. It also verifies a valid batch composes correctly.
Validation:
rustup run nightly tests/test_all.shcompleted withGATE PASSED, including std/no_std/serde tests, clippy, formatting, rustdoc, examples, benchmark smoke checks and the three ARM targets with and without serde. Stable clippy with serde also passed. The packaged crate was verified withcargo package --locked.