Skip to content

refactor(messages): add geometry operations for generated values - #4801

Merged
TomCC7 merged 3 commits into
cc/refactor/cdr-sensor-value-helpersfrom
cc/refactor/cdr-geometry-value-helpers
Oct 26, 2026
Merged

TomCC7 merged 3 commits into
cc/refactor/cdr-sensor-value-helpersfrom
cc/refactor/cdr-geometry-value-helpers

Conversation

@TomCC7

@TomCC7 TomCC7 commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Superseded by #4800. The implementation and regression tests from this PR are included in the consolidated message utility layer, with domain-module APIs and explicit ownership semantics.

The original branch and commits are preserved. Review the combined changes in #4800; the downstream TF layer #4803 now builds directly on it.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go2 replay realtime (arm64)

Details
Benchmark suite Current: f423112 Previous: 0ea05f6 Ratio
peak memory 1613.742 MB 1699.445 MB 0.95
peak threads 359 threads 357 threads 1.01
network (transport) 2724.304 MB 2725.914 MB 1.00
disk write 2.102 MB 1.469 MB 1.43
instructions 116.924 G 136.571 G 0.86

This comment was automatically generated by workflow using github-action-benchmark.

@TomCC7 TomCC7 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed to understand why this deserves a separate pr, should be just merged into PR layer 6

@TomCC7
TomCC7 merged commit 912279f into main Oct 26, 2026
26 of 32 checks passed
@TomCC7
TomCC7 deleted the cc/refactor/cdr-geometry-value-helpers branch October 26, 2026 19:07

This branch had an error being deployed

1 failed deployment
cachix — f4231128 Deployed Oct 23, 2026 by TomCC7 via cachix-build #14113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant