Repository navigation
Conversation
getAdditionalStats ran one findOne per row, ten per page, for both player and guild leaderboards. It now runs a single find with $in and puts the rows back in Redis order. A row whose player or guild document is missing from Mongo used to come back with no name. It is now left out of the page, the other rows keep their Redis positions, and the API logs how many rows each page dropped.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 21, 2026
This was referenced Oct 29, 2026
|
Deployment failed for project statsify with the following error: Learn More: https://vercel.com/statsify-net?upgradeToPro=build-rate-limit |
ugcodrr
added a commit
that referenced
this pull request
Nov 5, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Leaderboard pages ran one database query per row, and rows whose player or guild no longer exists came back with no name.
A full page loads in 3.2 ms instead of 6.7 ms at the median, and 25 ms instead of 51 ms with eight at once.
Merge order for the perf PRs, one at a time: #1005, #1006, #1007, #1002, #1009, #1010, #1011, #1014, #1012, then #1003 last.
Conflicts with #875 and with #1122, which batches the player lookup its own way.
Testing:
redis-cli ZADD player.stats.bedwars.overall.wins 999999 00000000000000000000000000000000, then open/leaderboard bedwars. The fake row is gone and the page starts at #2.Supersedes #846