Repository navigation
Conversation
A guild refresh looked up each expired member name through PlayerService.get, one findOne and a full deserialize per member. Fetch them all with one find and a projection; members it doesn't find still go through PlayerService.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 21, 2026
|
Deployment failed for project statsify with the following error: Learn More: https://vercel.com/statsify-net?upgradeToPro=build-rate-limit |
ugcodrr
marked this pull request as draft
November 3, 2026 04:28
ugcodrr
marked this pull request as ready for review
November 3, 2026 04:46
ugcodrr
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Guild refreshes spent most of their time looking up expired member names individually in the database.
If that name query fails, the refresh now errors instead of saving ERROR names for the guild's members.
A 125-member guild with all names expired and its players already in Mongo refreshed in about 15 ms instead of 280 ms.
Merge before #1037.
Merge order for the perf PRs is in #1002.
Testing: fetch a guild live, set its members'
expiresAtto 0 in Mongo, and fetch it again. Every member keeps the same name.