Repository navigation
fix(leaderboards): use a Map for rankings lookups - #1008
Merged
Merged
Conversation
@IsEnum(fields, { each: true }) rebuilt the list of all 2,718 player leaderboard
fields for every value, and getLeaderboardField searched the metadata array for
each field. Validate against a Set with IsEnum's message, and look fields up in
a Map built once per class. A test checks that scanMetadata returns each Player
and Guild key once, since a Map keeps the last entry for a repeated key.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 21, 2026
This was referenced Oct 21, 2026
ugcodrr
added a commit
that referenced
this pull request
Oct 22, 2026
ugcodrr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Rankings requests searched all 3,775 Player fields for each field they asked about.
Merge order for the perf PRs is in #1002.
Testing: POST
/player/leaderboards/rankingswith every field. The body matches main's.