Repository navigation
Conversation
@IsEnum(fields, { each: true }) rebuilt the list of all 2,718 player leaderboard
fields for every value, and getLeaderboardField searched the metadata array for
each field. Validate against a Set with IsEnum's message, and look fields up in
a Map built once per class. A test checks that scanMetadata returns each Player
and Guild key once, since a Map keeps the last entry for a repeated key.
A bad field in a player or guild rankings request got "each value in fields must be one of the following values: " with nothing after it, since IsEnum reads an array's indexes as enum keys. A valid field sent as a string instead of an array passed validation, was ranked letter by letter and threw a 500. - Name the values that aren't leaderboard fields, e.g. unknown leaderboard field: "stats.bedwars.foo" - Answer anything but an array with a 400: fields must be an array of leaderboard fields - Give guild rankings the same check - Run apps/api's in-source tests, for the message test
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 21, 2026
ugcodrr
added a commit
that referenced
this pull request
Oct 22, 2026
|
Deployment failed for project statsify with the following error: Learn More: https://vercel.com/statsify-net?upgradeToPro=build-rate-limit |
ugcodrr
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: A bad field in a rankings or leaderboard request got a 400 that ended at "must be one of the following values: " and never named the field.
Merge order for the perf PRs is in #1002. Conflicts with #875 and #1053 in the player DTOs.
Testing: POST
{"uuid": "<uuid>", "fields": ["stats.bedwars.foo"]}to/player/leaderboards/rankings, and the 400 says unknown leaderboard field: "stats.bedwars.foo".