Repository navigation
Conversation
PlayerService.saveOne and SessionService.resetPlayer handed Mongoose the flat serialized document, with keys like "stats.bedwars.overall.wins". Mongoose casts a replacement by building a document and setting each key, and its change tracking rescans every modified path on each set, so a save with K keys cost O(K²): about 100 ms for a player with 3,200 keys. Passing the same document unflattened avoids that: about 18 ms for that player, and 6.5 ms instead of 12 ms for an average one. The stored documents are byte-identical, BSON number types and key order included. Guild saves keep the flat document. Their cost is casting the members array, not the dotted keys, so nesting doesn't change it.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Player saves and session resets passed Mongoose a flat document with thousands of dotted keys, and its change tracking slows down with the square of that count.
#1006 is stacked on this PR. Merge order for the perf PRs is in #1002.
Testing: save the same big player on main and here. The stored documents match.