Repository navigation
Conversation
…racter getImageData on a font atlas rasterises the whole atlas, and fillCharacter called it for every character drawn, which was most of a card's render time. Each renderer now keeps a glyph's ImageData after the first read, keyed by the character, and drops them when its atlases are reloaded. The pixels are only read, never changed, so output is identical.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 21, 2026
Member
Author
|
Superseded by #1042, which now has these glyph-cache changes and the per-row drawing in one PR against main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #1042
Description: Every character on a card read its glyph's pixels from the font atlas, and on skia-canvas 3 each read redraws the whole atlas.
Merge order for the perf PRs is in #1002.
Testing: render any profile on main and here. The PNGs are byte for byte the same.