Repository navigation
Conversation
getSkin has looked skins up by usernameToLower since #639, but the Skin schema never had that field. Every lookup by name scanned the whole skins collection, found nothing, and asked Mojang twice. Skins now store usernameToLower, with an index. A name lookup takes the most recently refreshed skin with that name, since an old owner's skin can still carry a name after a rename. When the session server fails, the cached skin is only used if it belongs to the uuid Mojang gave for the name, so a name never falls back to its old owner's skin. Skins saved before this change have no usernameToLower until they are saved again or backfilled. Until then their name lookups go to Mojang, as they do today.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This was referenced Oct 21, 2026
|
Deployment failed for project statsify with the following error: Learn More: https://vercel.com/docs/limits#rate-limits |
ugcodrr
added a commit
that referenced
this pull request
Nov 5, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Skin lookups by name query usernameToLower, but skins never stored it, so every name lookup scanned the skins collection and went back to Mojang.
#1014 is stacked on this PR. Merge order for the perf PRs is in #1002.
Testing: request
/skin/textures?player=<name>twice. The second answer comes from the database.