Skip to content

perf(vpi): snapshot pending deposits once per edge batch - #2450

Merged
mergify[bot] merged 1 commit into
masterfrom
stack/tignear/perf/vpi-handle-names/snapshot-pending-deposits-once-per-edge-batch--2a51a4ec
Oct 28, 2026
Merged

mergify[bot] merged 1 commit into
masterfrom
stack/tignear/perf/vpi-handle-names/snapshot-pending-deposits-once-per-edge-batch--2a51a4ec

Conversation

@tignear

@tignear tignear commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Queued writes cloned the full deposit map into the open clock-edge batch
after every input write. Keep that batch attached to the current deposits
and freeze its map once before a member transitions again or before replay.
Closed batches retain their own per-edge values and callback overrides keep
the existing replay behavior. This avoids repeated full-map and BigUint
copies while collecting simultaneous input writes.

Extend the queued-edge regression stimulus with overwritten data deposits
before and after clock transitions. Validation: focused edge-value regression,
all 68 VPI unit/API tests, all 10 ignored cocotb integrations, all-target
clippy with warnings denied, and workspace formatting.

Depends-On: #2449

Queued writes cloned the full deposit map into the open clock-edge batch
after every input write. Keep that batch attached to the current deposits
and freeze its map once before a member transitions again or before replay.
Closed batches retain their own per-edge values and callback overrides keep
the existing replay behavior. This avoids repeated full-map and BigUint
copies while collecting simultaneous input writes.

Extend the queued-edge regression stimulus with overwritten data deposits
before and after clock transitions. Validation: focused edge-value regression,
all 68 VPI unit/API tests, all 10 ignored cocotb integrations, all-target
clippy with warnings denied, and workspace formatting.

Change-Id: I2a51a4eca0ff3f094e20b289f003f23344612ea6
@tignear

tignear commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 perf(vpi): avoid allocating empty names for temporary handles #2449
2 perf(vpi): snapshot pending deposits once per edge batch #2450 👈

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T13:37:17.067149Z 0a020d3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tignear tignear added the merge-ready Request merging through Mergify after required checks label Oct 28, 2026
@mergify mergify Bot added the queued Mergify queue entry label Oct 28, 2026
@mergify

mergify Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

✅ Merged into master as 8254d67 at 15:25 UTC

1 h 29 min in the queue, 31 min of it CI.

So far

Merge conditions: 8 of 8 met

This pull request

Condition
✅ depends-on = celox-sim/celox#2449

The batch, tested on draft #2456

Condition Required by
✅ check-success = Conventional Commit title —
✅ check-success = Queue validation —
✅ any of: check-success = @github-actions/Lint & Format, check-neutral = @github-actions/Lint & Format, check-skipped = @github-actions/Lint & Format GitHub repository ruleset rule master
✅ any of: check-success = @github-actions/Rust Test & NAPI Build, check-neutral = @github-actions/Rust Test & NAPI Build, check-skipped = @github-actions/Rust Test & NAPI Build GitHub repository ruleset rule master
✅ any of: check-success = @github-actions/JS Test (Ubuntu), check-neutral = @github-actions/JS Test (Ubuntu), check-skipped = @github-actions/JS Test (Ubuntu) GitHub repository ruleset rule master
✅ any of: check-success = @github-actions/Conventional Commit title, check-neutral = @github-actions/Conventional Commit title, check-skipped = @github-actions/Conventional Commit title GitHub repository ruleset rule master
✅ any of: check-success = @github-actions/Queue validation, check-neutral = @github-actions/Queue validation, check-skipped = @github-actions/Queue validation GitHub repository ruleset rule master

Times in UTC · dashboard · how the merge queue works

Base automatically changed from stack/tignear/perf/vpi-handle-names/avoid-allocating-empty-names-tmp-handles--bf866696 to master October 28, 2026 15:09
@mergify
mergify Bot merged commit 8254d67 into master Oct 28, 2026
24 checks passed
@mergify
mergify Bot deleted the stack/tignear/perf/vpi-handle-names/snapshot-pending-deposits-once-per-edge-batch--2a51a4ec branch October 28, 2026 15:25
@mergify mergify Bot removed the queued Mergify queue entry label Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-ready Request merging through Mergify after required checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant