Repository navigation
perf(vpi): snapshot pending deposits once per edge batch - #2450
Merged
Conversation
Queued writes cloned the full deposit map into the open clock-edge batch after every input write. Keep that batch attached to the current deposits and freeze its map once before a member transitions again or before replay. Closed batches retain their own per-edge values and callback overrides keep the existing replay behavior. This avoids repeated full-map and BigUint copies while collecting simultaneous input writes. Extend the queued-edge regression stimulus with overwritten data deposits before and after clock transitions. Validation: focused edge-value regression, all 68 VPI unit/API tests, all 10 ignored cocotb integrations, all-target clippy with warnings denied, and workspace formatting. Change-Id: I2a51a4eca0ff3f094e20b289f003f23344612ea6
Contributor
Author
|
This pull request is part of a Mergify stack:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
✅ Merged into
|
| Condition | |
|---|---|
| ✅ | depends-on = celox-sim/celox#2449 |
The batch, tested on draft #2456
| Condition | Required by | |
|---|---|---|
| ✅ | check-success = Conventional Commit title |
— |
| ✅ | check-success = Queue validation |
— |
| ✅ | any of: check-success = @github-actions/Lint & Format, check-neutral = @github-actions/Lint & Format, check-skipped = @github-actions/Lint & Format |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/Rust Test & NAPI Build, check-neutral = @github-actions/Rust Test & NAPI Build, check-skipped = @github-actions/Rust Test & NAPI Build |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/JS Test (Ubuntu), check-neutral = @github-actions/JS Test (Ubuntu), check-skipped = @github-actions/JS Test (Ubuntu) |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/Conventional Commit title, check-neutral = @github-actions/Conventional Commit title, check-skipped = @github-actions/Conventional Commit title |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/Queue validation, check-neutral = @github-actions/Queue validation, check-skipped = @github-actions/Queue validation |
GitHub repository ruleset rule master |
Times in UTC · dashboard · how the merge queue works
This was referenced Oct 28, 2026
Base automatically changed from
stack/tignear/perf/vpi-handle-names/avoid-allocating-empty-names-tmp-handles--bf866696
to
master
October 28, 2026 15:09
This was referenced Oct 28, 2026
mergify
Bot
deleted the
stack/tignear/perf/vpi-handle-names/snapshot-pending-deposits-once-per-edge-batch--2a51a4ec
branch
October 28, 2026 15:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queued writes cloned the full deposit map into the open clock-edge batch
after every input write. Keep that batch attached to the current deposits
and freeze its map once before a member transitions again or before replay.
Closed batches retain their own per-edge values and callback overrides keep
the existing replay behavior. This avoids repeated full-map and BigUint
copies while collecting simultaneous input writes.
Extend the queued-edge regression stimulus with overwritten data deposits
before and after clock transitions. Validation: focused edge-value regression,
all 68 VPI unit/API tests, all 10 ignored cocotb integrations, all-target
clippy with warnings denied, and workspace formatting.
Depends-On: #2449