Skip to content

perf(vpi): avoid allocating empty names for temporary handles - #2449

Merged
mergify[bot] merged 1 commit into
masterfrom
stack/tignear/perf/vpi-handle-names/avoid-allocating-empty-names-tmp-handles--bf866696
Oct 28, 2026
Merged

mergify[bot] merged 1 commit into
masterfrom
stack/tignear/perf/vpi-handle-names/avoid-allocating-empty-names-tmp-handles--bf866696

Conversation

@tignear

@tignear tignear commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Every callback registration allocated two empty CString buffers for its
handle name and full name. Keep unnamed callback, iterator and constant
handles without owned names and return the shared empty C string for those
properties. Named scopes and signals retain their owned strings.

Extend existing public API regressions to check empty callback and iterator
names alongside the named hierarchy. Validation: all 68 VPI unit/API tests,
all 10 ignored cocotb integrations, all-target clippy with warnings denied,
and workspace formatting.

Every callback registration allocated two empty CString buffers for its
handle name and full name. Keep unnamed callback, iterator and constant
handles without owned names and return the shared empty C string for those
properties. Named scopes and signals retain their owned strings.

Extend existing public API regressions to check empty callback and iterator
names alongside the named hierarchy. Validation: all 68 VPI unit/API tests,
all 10 ignored cocotb integrations, all-target clippy with warnings denied,
and workspace formatting.

Change-Id: Ibf866696869af6e0ab4b5e2720e9c2a8a8f7a738
@tignear

tignear commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 perf(vpi): avoid allocating empty names for temporary handles #2449 👈
2 perf(vpi): snapshot pending deposits once per edge batch #2450

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T13:37:11.035785Z 66f7085 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tignear tignear added the merge-ready Request merging through Mergify after required checks label Oct 28, 2026
@mergify mergify Bot added the queued Mergify queue entry label Oct 28, 2026
@mergify

mergify Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

✅ Merged into master as 528eca9 at 15:09 UTC

Merged together with #2411, #2446. 1 h 14 min in the queue, 30 min of it CI.

So far

Merge conditions: 7 of 7 met

The batch, tested on draft #2452

Condition Required by
✅ check-success = Conventional Commit title —
✅ check-success = Queue validation —
✅ any of: check-success = @github-actions/Lint & Format, check-neutral = @github-actions/Lint & Format, check-skipped = @github-actions/Lint & Format GitHub repository ruleset rule master
✅ any of: check-success = @github-actions/Rust Test & NAPI Build, check-neutral = @github-actions/Rust Test & NAPI Build, check-skipped = @github-actions/Rust Test & NAPI Build GitHub repository ruleset rule master
✅ any of: check-success = @github-actions/JS Test (Ubuntu), check-neutral = @github-actions/JS Test (Ubuntu), check-skipped = @github-actions/JS Test (Ubuntu) GitHub repository ruleset rule master
✅ any of: check-success = @github-actions/Conventional Commit title, check-neutral = @github-actions/Conventional Commit title, check-skipped = @github-actions/Conventional Commit title GitHub repository ruleset rule master
✅ any of: check-success = @github-actions/Queue validation, check-neutral = @github-actions/Queue validation, check-skipped = @github-actions/Queue validation GitHub repository ruleset rule master

Times in UTC · dashboard · how the merge queue works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-ready Request merging through Mergify after required checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant