Skip to content

merge queue: checking #2450 on master (320e8bf), stacked on #2411, #2446 and #2449 - #2456

Closed
mergify[bot] wants to merge 5 commits into
masterfrom
mergify/merge-queue/d3bc6988ff
Closed

mergify[bot] wants to merge 5 commits into
masterfrom
mergify/merge-queue/d3bc6988ff

Conversation

@mergify

@mergify mergify Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Note

This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch tolerant-miche-ytv8fm of the changes queue, to test #2450 before it merges into master. Pushing to this branch or closing this pull request removes #2450 from the queue.

What this draft tests

Mergify checks that #2450 still passes CI once combined with everything queued ahead of it. CI runs on this draft's code, built in this order:

  1. master at 320e8bf
  2. the 3 pull requests queued ahead of this batch, listed below, which bring the tip to 9f4c75a
  3. #2450, the pull request of this batch

The check is speculative: it assumes the pull requests ahead will merge, so it starts without waiting for them.

This batch comes from splitting a batch whose checks failed: Mergify checks smaller batches to find which pull request is responsible. The batches it was split from are listed below.

🎉 Where it stands: checks passed

CI passed on this draft.

Follow the changes queue in the dashboard

What happens next

  • Once the pull requests ahead have merged, Mergify merges #2450 into master and closes this draft.
  • If a pull request ahead fails or leaves the queue without merging, this batch is requeued and checked again on a new draft: these checks assumed it would merge.

Tip

A red check is not necessarily caused by this batch. These checks run on a tip that also carries the commits of the 3 pull requests ahead, so a failure here can come from them as much as from #2450. See only this batch's changes.

Queued ahead of this batch

These pull requests entered the queue before this batch and are not part of it.

Bisected from a failed batch:

Metadata for CI tooling, read by mergify ci
---
all_scopes: false
checking_base_sha: 9f4c75a5f0a2695976603795b9004cec693e578a
previous_check_retries: []
previous_failed_batches:
  - batch_pr_head_sha: e803975d74643d51f638e309856436f4693b3f26
    batch_pr_number: 2455
    checked_pull_requests:
      - 2450
      - 2390
      - 2407
    draft_pr_head_sha: e803975d74643d51f638e309856436f4693b3f26
    draft_pr_number: 2455
pull_requests:
  - number: 2450
    scopes:
      - core
scopes:
  - core
...
Required conditions of queue rule changes for merge
  • check-success = Conventional Commit title
  • check-success = Queue validation
  • depends-on = celox-sim/celox#2449 [⛓️ perf(vpi): avoid allocating empty names for temporary handles #2449]
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-success = @github-actions/Lint & Format
    • check-neutral = @github-actions/Lint & Format
    • check-skipped = @github-actions/Lint & Format
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-success = @github-actions/Rust Test & NAPI Build
    • check-neutral = @github-actions/Rust Test & NAPI Build
    • check-skipped = @github-actions/Rust Test & NAPI Build
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-success = @github-actions/JS Test (Ubuntu)
    • check-neutral = @github-actions/JS Test (Ubuntu)
    • check-skipped = @github-actions/JS Test (Ubuntu)
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-success = @github-actions/Conventional Commit title
    • check-neutral = @github-actions/Conventional Commit title
    • check-skipped = @github-actions/Conventional Commit title
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-success = @github-actions/Queue validation
    • check-neutral = @github-actions/Queue validation
    • check-skipped = @github-actions/Queue validation
Required conditions to stay in the queue

tignear and others added 5 commits October 28, 2026 22:32
Queued writes cloned the full deposit map into the open clock-edge batch
after every input write. Keep that batch attached to the current deposits
and freeze its map once before a member transitions again or before replay.
Closed batches retain their own per-edge values and callback overrides keep
the existing replay behavior. This avoids repeated full-map and BigUint
copies while collecting simultaneous input writes.

Extend the queued-edge regression stimulus with overwritten data deposits
before and after clock transitions. Validation: focused edge-value regression,
all 68 VPI unit/API tests, all 10 ignored cocotb integrations, all-target
clippy with warnings denied, and workspace formatting.

Change-Id: I2a51a4eca0ff3f094e20b289f003f23344612ea6
@mergify mergify Bot closed this Oct 28, 2026
@mergify
mergify Bot deleted the mergify/merge-queue/d3bc6988ff branch October 28, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant