Skip to content

merge queue: checking #2390 on master (320e8bf), stacked on 4 pull requests ahead - #2457

Closed
mergify[bot] wants to merge 7 commits into
masterfrom
mergify/merge-queue/d856107304
Closed

merge queue: checking #2390 on master (320e8bf), stacked on 4 pull requests ahead#2457
mergify[bot] wants to merge 7 commits into
masterfrom
mergify/merge-queue/d856107304

Conversation

@mergify

@mergify mergify Bot commented Oct 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Note

This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch jubilant-clementine-fy6q5c of the changes queue, to test #2390 before it merges into master.

What this draft tests

Mergify checks that #2390 still passes CI once combined with everything queued ahead of it. CI runs on this draft's code, built in this order:

  1. master at 320e8bf
  2. the 4 pull requests queued ahead of this batch, listed below, which bring the tip to dcdd7f0
  3. #2390, the pull request of this batch

The check is speculative: it assumes the pull requests ahead will merge, so it starts without waiting for them.

This batch comes from splitting a batch whose checks failed: Mergify checks smaller batches to find which pull request is responsible. The batches it was split from are listed below.

🕵️ Where it stands: failed, waiting for the pull requests ahead

The checks of this draft failed. Mergify waits for the pull requests ahead to finish, since the failure may be theirs.

Follow the changes queue in the dashboard

What happens next

  • The checks of this draft can no longer change the outcome: what comes next depends on the pull requests ahead.
  • If a pull request ahead fails or leaves the queue without merging, this batch is requeued and checked again on a new draft: these checks assumed it would merge.
  • Otherwise, once the pull requests ahead are done, Mergify removes #2390 from the queue and closes this draft.

Tip

A red check is not necessarily caused by this batch. These checks run on a tip that also carries the commits of the 4 pull requests ahead, so a failure here can come from them as much as from #2390. See only this batch's changes.

Queued ahead of this batch

These pull requests entered the queue before this batch and are not part of it.

Bisected from a failed batch:

Metadata for CI tooling, read by mergify ci 
---
all_scopes: false
checking_base_sha: dcdd7f0f4a10097cd39a288bad4bd535d3229363
previous_check_retries: []
previous_failed_batches:
  - batch_pr_head_sha: e803975d74643d51f638e309856436f4693b3f26
    batch_pr_number: 2455
    checked_pull_requests:
      - 2450
      - 2390
      - 2407
    draft_pr_head_sha: e803975d74643d51f638e309856436f4693b3f26
    draft_pr_number: 2455
pull_requests:
  - number: 2390
    scopes:
      - core
scopes:
  - core
...
Required conditions of queue rule changes for merge
  • check-success = Conventional Commit title
  • check-success = Queue validation
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-neutral = @github-actions/Lint & Format
    • check-skipped = @github-actions/Lint & Format
    • check-success = @github-actions/Lint & Format
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-neutral = @github-actions/Rust Test & NAPI Build
    • check-skipped = @github-actions/Rust Test & NAPI Build
    • check-success = @github-actions/Rust Test & NAPI Build
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-neutral = @github-actions/JS Test (Ubuntu)
    • check-skipped = @github-actions/JS Test (Ubuntu)
    • check-success = @github-actions/JS Test (Ubuntu)
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-neutral = @github-actions/Conventional Commit title
    • check-skipped = @github-actions/Conventional Commit title
    • check-success = @github-actions/Conventional Commit title
  • any of [🛡 GitHub repository ruleset rule master]:
    • check-neutral = @github-actions/Queue validation
    • check-skipped = @github-actions/Queue validation
    • check-success = @github-actions/Queue validation
Required conditions to stay in the queue

tignear and others added 7 commits October 28, 2026 22:23
@tignear
feat(sv): implement enumerated type methods
9ee3c10 
Enum-typed expressions accept `first`, `last`, `next(N)`, `prev(N)`, `num`
and `name` (IEEE 1800-2023 6.19.5), with or without parentheses (6.19.5.7),
on variables, array and container elements, class properties, static
properties, function and method results, casts, enum constants and the
results of other enum methods.

Types now carry the members of an enumeration with their names, base
width, signedness and state count. The methods bind to a new
`Callee::Lookup` IR call that evaluates its selector once and returns the
value of the first key it matches by case equality, else a default; the
frontend lowers it to multiplexers whose selector copies share one node.
A receiver with side effects therefore runs once, and only designs that
call these methods pay for them.

`next`/`prev` wrap around and take the count modulo the number of
members; a value that is no member, including one with unknown bits,
gives the base type's default initial value ('x for a 4-state base,
Table 6-7). `name` returns the empty string for such a value (6.19.5.6).

Change-Id: Icf20fb1bef13ec48958bd50e14f82790e72f516a
@tignear
perf(vpi): snapshot pending deposits once per edge batch
0a020d3 
Queued writes cloned the full deposit map into the open clock-edge batch
after every input write. Keep that batch attached to the current deposits
and freeze its map once before a member transitions again or before replay.
Closed batches retain their own per-edge values and callback overrides keep
the existing replay behavior. This avoids repeated full-map and BigUint
copies while collecting simultaneous input writes.

Extend the queued-edge regression stimulus with overwritten data deposits
before and after clock transitions. Validation: focused edge-value regression,
all 68 VPI unit/API tests, all 10 ignored cocotb integrations, all-target
clippy with warnings denied, and workspace formatting.

Change-Id: I2a51a4eca0ff3f094e20b289f003f23344612ea6
@mergify @mergify-commit-signer
Merge of #2411
fa99924
@mergify @mergify-commit-signer
Merge of #2446
0e6fb78
@mergify @mergify-commit-signer
Merge of #2449
3771c2e
@mergify @mergify-commit-signer
Merge of #2450
dcdd7f0
@mergify @mergify-commit-signer
Merge of #2390
63d6d8e
@mergify mergify Bot mentioned this pull request Oct 28, 2026
Merged
@mergify mergify Bot closed this Oct 28, 2026
@mergify
mergify Bot deleted the mergify/merge-queue/d856107304 branch October 28, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tignear