Repository navigation
feat(sv): support the $swrite family - #2403
mergify[bot] merged 1 commit into
Conversation
|
This pull request is part of a Mergify stack:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3daf51501f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tignear
added
merge-ready
|
Queued — the merge queue status continues in this comment ↓. |
290e018 to
27e5a3d
Compare
3daf515 to
b940cca
Compare
Revision history
|
b940cca to
0ed3f7e
Compare
27e5a3d to
d484bec
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ed3f7ebcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ed3f7ebcc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d484bec to
3703011
Compare
0ed3f7e to
91edc39
Compare
3703011 to
f7aeb22
Compare
91edc39 to
b2997d3
Compare
tignear
added
the
merge-ready
b2997d3 to
8f07632
Compare
f7aeb22 to
5ab0f09
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f076321cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🚫 Left the queue22 min in the queue, with no time running CI. So far
Reason Pull request #2403 has been dequeued Queue conditions are not satisfied:
Hint You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. Requeued — the merge queue status continues in this comment ↓. Times in UTC · dashboard · how the merge queue works |
mergify
Bot
added
dequeued
8f07632 to
ce4dbef
Compare
5ab0f09 to
bfa9061
Compare
mergify
Bot
removed
the
dequeued
ce4dbef to
5edf99e
Compare
bfa9061 to
242cd1f
Compare
🚫 Left the queue2 min in the queue, with no time running CI. So far
Reason Pull request #2403 has been dequeued Queue conditions are not satisfied:
Hint You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. Requeued — the merge queue status continues in this comment ↓. Times in UTC · dashboard · how the merge queue works |
mergify
Bot
added
dequeued
Implement `$swrite`, `$swriteb`, `$swriteo` and `$swriteh` (IEEE 1800-2023 21.3.3). Like `$write`, a string literal that no conversion consumes is a format, a later one included, and each value without a conversion of its own is written in the task's radix, a string as text and a real as `$write` writes it. `$display`, `$write`, `$fdisplay` and `$fwrite` now also treat a later unconsumed string literal as a further format, as Verilator, Icarus and xezim do (21.2.1.1), instead of printing its conversions literally. The analyzer builds that format and binds the call as the `$sformatf` string operation, then assigns the result to the output, a string variable, a function's return variable or a string class property. The shared swrite_matches_write case compares each form with `$write` of the same arguments; Verilator 5.052, Icarus 13.0 and xezim 0.11.3 pass it. Change-Id: Ie03af76400361cd0410abcac91959d1c272c56a1
242cd1f to
85f9c72
Compare
5edf99e to
0e81942
Compare
mergify
Bot
added
queued
✅ Merged into
|
| Condition | |
|---|---|
| ✅ | depends-on = celox-sim/celox#2402 |
The batch, tested on draft #2488
| Condition | Required by | |
|---|---|---|
| ✅ | check-success = Conventional Commit title |
— |
| ✅ | check-success = Queue validation |
— |
| ✅ | any of: check-success = @github-actions/Lint & Format, check-neutral = @github-actions/Lint & Format, check-skipped = @github-actions/Lint & Format |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/Rust Test & NAPI Build, check-neutral = @github-actions/Rust Test & NAPI Build, check-skipped = @github-actions/Rust Test & NAPI Build |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/JS Test (Ubuntu), check-neutral = @github-actions/JS Test (Ubuntu), check-skipped = @github-actions/JS Test (Ubuntu) |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/Conventional Commit title, check-neutral = @github-actions/Conventional Commit title, check-skipped = @github-actions/Conventional Commit title |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/Queue validation, check-neutral = @github-actions/Queue validation, check-skipped = @github-actions/Queue validation |
GitHub repository ruleset rule master |
Times in UTC · dashboard · how the merge queue works
Implement
$swrite,$swriteb,$swriteoand$swriteh(IEEE 1800-202321.3.3). Like
$write, a string literal that no conversion consumes is aformat, a later one included, and each value without a conversion of its own
is written in the task's radix, a string as text and a real as
$writewritesit.
$display,$write,$fdisplayand$fwritenow also treat a laterunconsumed string literal as a further format, as Verilator, Icarus and xezim
do (21.2.1.1), instead of printing its conversions literally. The analyzer
builds that format and binds the call as the
$sformatfstring operation,then assigns the result to the output, a string variable, a function's return
variable or a string class property.
The shared swrite_matches_write case compares each form with
$writeof thesame arguments; Verilator 5.052, Icarus 13.0 and xezim 0.11.3 pass it.
Depends-On: #2402