Repository navigation
ci: key the vtest dependency cache by the executor's build plan - #2487
Merged
mergify[bot] merged 1 commit intoOct 28, 2026
Conversation
After #2467 moved the test build to the `vtest` profile, Rust Tests jobs still restored the old `vtest-v1` cache, built for the previous plan, and compiled the dependencies again in the executor step (10 minutes and more). The warm workflow ran on the merge but found the same key and skipped its build, since the rust-cache key does not change with Cargo commands or profiles. Key the cache by `scripts/run-vtest.mjs`, which holds the executor's profile, scope and features, in both CI and the warm workflow. A change of the plan is then a new key that the warm run on master populates. Validation: repository workflow tests (26) pass, including the key parity between CI and the warm workflow; actionlint reports only its unknown `ubuntu-26.04-arm` label. Change-Id: I9b8d55c3142c7a3b00a751b6f005cbb57fa5d2f4
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tignear
added
merge-urgent
mergify
Bot
added
merge-ready
Contributor
✅ Merged into
|
| Condition | Required by | |
|---|---|---|
| ✅ | check-success = Conventional Commit title |
— |
| ✅ | check-success = Queue validation |
— |
| ✅ | any of: check-success = @github-actions/Lint & Format, check-neutral = @github-actions/Lint & Format, check-skipped = @github-actions/Lint & Format |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/Rust Test & NAPI Build, check-neutral = @github-actions/Rust Test & NAPI Build, check-skipped = @github-actions/Rust Test & NAPI Build |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/JS Test (Ubuntu), check-neutral = @github-actions/JS Test (Ubuntu), check-skipped = @github-actions/JS Test (Ubuntu) |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/Conventional Commit title, check-neutral = @github-actions/Conventional Commit title, check-skipped = @github-actions/Conventional Commit title |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/Queue validation, check-neutral = @github-actions/Queue validation, check-skipped = @github-actions/Queue validation |
GitHub repository ruleset rule master |
Times in UTC · dashboard · how the merge queue works
This was referenced Oct 28, 2026
mergify
Bot
deleted the
stack/tignear/ci/vtest-cache-key/key-vtest-dep-cache-executor-s-build-plan--9b8d55c3
branch
October 28, 2026 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #2467 moved the test build to the
vtestprofile, Rust Tests jobsstill restored the old
vtest-v1cache, built for the previous plan, andcompiled the dependencies again in the executor step (10 minutes and more).
The warm workflow ran on the merge but found the same key and skipped its
build, since the rust-cache key does not change with Cargo commands or
profiles.
Key the cache by
scripts/run-vtest.mjs, which holds the executor'sprofile, scope and features, in both CI and the warm workflow. A change of
the plan is then a new key that the warm run on master populates.
Validation: repository workflow tests (26) pass, including the key parity
between CI and the warm workflow; actionlint reports only its unknown
ubuntu-26.04-armlabel.