Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4167642da2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Queued — the merge queue status continues in this comment ↓. |
4167642 to
a9fdc69
Compare
Revision history
|
|
This pull request is part of a Mergify stack:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9fdc69a44
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a9fdc69 to
9f1d0a1
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f1d0a1a20
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9f1d0a1 to
cf97c42
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf97c42f40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cf97c42 to
24785f2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24785f259b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
24785f2 to
31dd1c3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31dd1c3940
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
31dd1c3 to
764af58
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Unpacked structures (IEEE 1800-2023 7.2) were rejected. A variable of
an unpacked structure type is now a set of leaf variables, one per
member that is not itself an unpacked structure, named by the member
path (`s.a.b`). Each leaf keeps its member's type, so `string`, class
handle, enumeration and 2-state or 4-state integral members behave like
variables of those types, and the heap collector finds handle members
through their own slots. A whole structure value is the concatenation
of its leaves; it only lives within one evaluation.
Supported:
- module variables, procedural locals, and subroutine arguments of any
direction and results (a structure argument is passed flat and copied
into and out of its members' variables);
- member reads and writes, whole assignment (also continuous, in
`always_comb` and nonblocking), `==`, `!=`, `===`, `!==`, `?:`;
- assignment patterns: positional, by member name, `default` (applied
recursively to nested structures, 10.9.2) and typed `T'{...}`.
Only patterns and values of the same structure type may be assigned
(6.22.3); other operators, selects and casts of a whole structure are
rejected. Ports, nets, parameters, class properties, arrays and
container elements of an unpacked structure type, and members with
unpacked dimensions or default values, are rejected with dedicated
diagnostics; unpacked unions stay unsupported (#440).
The concatenation parts of an assignment target now take the raw bits
of the value, so a string member receives its handle instead of the
bytes of an integral value. sv-tests chapter-7/structures/unpacked/basic
now passes in both state modes. Icarus 13.0 does not support unpacked
structures, Verilator 5.052 misapplies a nested `default`, and xezim
0.11.3 shows four defects on the new cases; these are retained as
reviewed limitations and xezim review entries.
Change-Id: I9a94c0cc4394766e17f949f72af405c2a3442b0f
764af58 to
5618438
Compare
tignear
added
the
merge-ready
⏳ Checks deferred · conflict with a pull request aheadSo far
Reason The pull request conflicts with at least one of the pull requests ahead in queue: #2402, #2403 Conflicting files: Times in UTC · dashboard · how the merge queue works |
Unpacked structures (IEEE 1800-2023 7.2) were rejected. A variable of
an unpacked structure type is now a set of leaf variables, one per
member that is not itself an unpacked structure, named by the member
path (
s.a.b). Each leaf keeps its member's type, sostring, classhandle, enumeration and 2-state or 4-state integral members behave like
variables of those types, and the heap collector finds handle members
through their own slots. A whole structure value is the concatenation
of its leaves; it only lives within one evaluation.
Supported:
direction and results (a structure argument is passed flat and copied
into and out of its members' variables);
always_comband nonblocking),==,!=,===,!==,?:;default(appliedrecursively to nested structures, 10.9.2) and typed
T'{...}.Only patterns and values of the same structure type may be assigned
(6.22.3); other operators, selects and casts of a whole structure are
rejected. Ports, nets, parameters, class properties, arrays and
container elements of an unpacked structure type, and members with
unpacked dimensions or default values, are rejected with dedicated
diagnostics; unpacked unions stay unsupported (#440).
The concatenation parts of an assignment target now take the raw bits
of the value, so a string member receives its handle instead of the
bytes of an integral value. sv-tests chapter-7/structures/unpacked/basic
now passes in both state modes. Icarus 13.0 does not support unpacked
structures, Verilator 5.052 misapplies a nested
default, and xezim0.11.3 shows four defects on the new cases; these are retained as
reviewed limitations and xezim review entries.