Repository navigation
feat(sv): support class properties of unpacked structure type - #2419
Conversation
|
This pull request is part of a Mergify stack:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6dd66761ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6dd6676 to
c3f54de
Compare
a9fdc69 to
9f1d0a1
Compare
Revision history
|
|
Queued — the merge queue status continues in this comment ↓. |
c3f54de to
c71b11a
Compare
9f1d0a1 to
cf97c42
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c71b11ab8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c71b11a to
ecce9b8
Compare
cf97c42 to
24785f2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecce9b84d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
24785f2 to
31dd1c3
Compare
ecce9b8 to
9c93687
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c93687726
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9c93687 to
98ce935
Compare
31dd1c3 to
764af58
Compare
98ce935 to
88a469a
Compare
764af58 to
5618438
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88a469a64a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
88a469a to
4f9dad1
Compare
A class property of an unpacked structure type was rejected. Its leaf members are now laid out as ordinary properties named by their member path (`orig.m_type`), so a `string` or class handle member is a handle property the collector traces, and a 4-state member keeps its X/Z bits. The class records the property and its structure-typed members (`Class::aggregates`) for lookup and hiding. `h.p.m` and an unqualified `p.m` inside a method resolve through the member path to the leaf property, including `h.p.m.q` through a handle member. A whole property `h.p` reads as the concatenation of its leaf loads; assigning it, from a pattern, a variable, another property, a conditional or a call, stores each leaf, evaluating the value once. Declaration initializers run in the constructor in declaration order, and a shallow copy copies the members. Methods returning a structure are now recognised when checking an assignment's type. Static, `rand` and `const` properties of an unpacked structure type stay unsupported with dedicated diagnostics. Icarus 13.0 still lacks unpacked structures; xezim 0.11.3 formats string members of such properties as packed values, which the review retains. Change-Id: I8d7ebe18fdf58ac33c7b1f2f76b7e27bf598b542
tignear
added
the
merge-ready
5618438 to
5760816
Compare
4f9dad1 to
23214db
Compare
✅ Merged into
|
| Condition | |
|---|---|
| ✅ | depends-on=celox-sim/celox#2419 |
| ✅ | any of: depends-on = celox-sim/celox#2415, number != 2419 |
The batch, tested on draft #2495
| Condition | Required by | |
|---|---|---|
| ✅ | check-success = Conventional Commit title |
— |
| ✅ | check-success = Queue validation |
— |
| ✅ | any of: check-success = @github-actions/Lint & Format, check-neutral = @github-actions/Lint & Format, check-skipped = @github-actions/Lint & Format |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/Rust Test & NAPI Build, check-neutral = @github-actions/Rust Test & NAPI Build, check-skipped = @github-actions/Rust Test & NAPI Build |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/JS Test (Ubuntu), check-neutral = @github-actions/JS Test (Ubuntu), check-skipped = @github-actions/JS Test (Ubuntu) |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/Conventional Commit title, check-neutral = @github-actions/Conventional Commit title, check-skipped = @github-actions/Conventional Commit title |
GitHub repository ruleset rule master |
| ✅ | any of: check-success = @github-actions/Queue validation, check-neutral = @github-actions/Queue validation, check-skipped = @github-actions/Queue validation |
GitHub repository ruleset rule master |
Times in UTC · dashboard · how the merge queue works
A class property of an unpacked structure type was rejected. Its leaf
members are now laid out as ordinary properties named by their member
path (
orig.m_type), so astringor class handle member is a handleproperty the collector traces, and a 4-state member keeps its X/Z bits.
The class records the property and its structure-typed members
(
Class::aggregates) for lookup and hiding.h.p.mand an unqualifiedp.minside a method resolve through themember path to the leaf property, including
h.p.m.qthrough a handlemember. A whole property
h.preads as the concatenation of its leafloads; assigning it, from a pattern, a variable, another property, a
conditional or a call, stores each leaf, evaluating the value once.
Declaration initializers run in the constructor in declaration order,
and a shallow copy copies the members. Methods returning a structure are
now recognised when checking an assignment's type.
Static,
randandconstproperties of an unpacked structure type stayunsupported with dedicated diagnostics. Icarus 13.0 still lacks unpacked
structures; xezim 0.11.3 formats string members of such properties as
packed values, which the review retains.
Depends-On: #2415