Repository navigation
refactor(research)!: remove the unused web research drivers and TCloud - #240
Merged
Merged
Conversation
No consumer imports runVerifiedResearchLoop, the web research worker, the adaptive, collection, or driving drivers, the claim-grounding verifier, or the investment-thesis task. They were the only code that browsed or called models, which the package boundary says Knowledge does not do, and the only users of the TCloud dependency. groundClaimInText stays for RAG answer scoring; claim ledgers and TrackedClaim stay for KbStore consumers. BREAKING CHANGE: the research driver, router, and investment-thesis exports are removed and @tangle-network/tcloud is no longer a dependency.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
tangletools
approved these changes
Oct 6, 2026
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved PR — 89d7b468
Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-06T07:06:46Z
drewstone
added a commit
that referenced
this pull request
Oct 6, 2026
…ge detection, and freshness stores (#242) refactor(sources)!: remove the unused authority source adapters, change detection, and freshness stores The `/sources` entry point (also re-exported from the root) shipped three authority adapters from #7 (2026-05-14): Cornell LII, IRS publications, and state Secretary of State. They came with a polite HTTP fetcher with an on-disk cache, HTML extraction, `detectChanges`, and filesystem and D1-stub freshness stores. Nothing outside this repository imports any of it. Its only in-repo user, the web research worker, was removed in #240. That leaves 1,471 source lines and 984 test lines, including a live-network test that CI enabled through `AGENT_KNOWLEDGE_RUN_NETWORK_TESTS`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The package says it "does not browse, call models, or run agents", but it shipped a web research stack that does:
runVerifiedResearchLoop, the TCloud-backed web worker and router client, and the adaptive, collection, and driving drivers. It also shipped the claim-grounding verifier and decorator, and an investment-thesis task with a 900-line answer set compiled intosrc/. Nothing outside this repository imports any of it. The stack is the only user of@tangle-network/tcloud, so every Knowledge release also had to fit the TCloud and Sandbox dependency cohort.Change
verified-research-loop,web-research-worker,adaptive-driver,collection-research-driver,research-driving-driver,investment-thesis-set,investment-thesis-task, andmaterial-facts-metric, with their tests (tests/loops/,tests/eval/, and the driver cases inclaim-persistence.test.ts).claim-grounding.tstogroundClaimInText, which RAG answer scoring uses.@tangle-network/tcloudfromdependencies. The lockfile loses 190 lines.scripts/prove-research-live.mjsandscripts/prove-research-transport.mjs, one-off proofs for that transport (refactor(research): published TCloud transport with compatible APIs and cancellation #222).verify-package.mjsno longer requiresrunVerifiedResearchLoop. Its obsolete two-agent "forbidden export" guards are gone becauseapi-surface.jsonalready records the exact export set.docs/results/*, and the investment answer key as a historical record. Each is marked historical, and its code links now point atbc2abe0, the last commit that contains the code.Kept: claim ledgers,
TrackedClaim, and theKbStoreclaim-ledger methods. Agent Runtime'sknowledge-improvement-jobtest callsstore.putClaimLedger.Consumer evidence
I extracted every identifier imported from
@tangle-network/agent-knowledge(named, type, namespace,import(), andcreateRequireforms) in:~/webband~/companycheckouts and worktrees (939 code files);~/codeon beelink1 (4,125 files) and drew-gtr-pro (5,711 files);None of the 69 removed exports is imported anywhere. The only textual matches are discovery docs that describe the API, and frozen bundles in discovery-lab preregistrations. Those bundles contain their own copy and do not resolve the package.
Why this is the right long-term shape
Knowledge owns knowledge state. Model calls and browsing belong to callbacks or Agent Runtime, as the README and AGENTS.md already state. Removing TCloud takes the package out of the TCloud and Sandbox cohort.
Cost
39 files, 52 insertions, 9,277 deletions (source 4,162 lines, tests 4,688, scripts 137, lockfile 190). Major version bump: consumers on
^19are unaffected until they move to 20. Risk: an unlisted private consumer of the research drivers. Rollback: revert this PR, or stay on 19.x.Verification (beelink1, merged with origin/main)
pnpm install --frozen-lockfile,pnpm lint(one existing warning inproposals.ts),pnpm typecheck,pnpm build, andpnpm run api:surface(950 exports) all pass.node scripts/check-version-bump.mjspasses: 19.1.5 -> 20.0.0 pays for the 69 export removals.pnpm testwith network tests: 872 passed, 2 skipped, 1 failed. The failure was an unhandled transaction error intests/kb-improvement/activation.test.tsunder full-suite load on the busy host. That file passes alone (9/9) and does not touch the removed code.pnpm run verify:packagefails the same way on main and on this branch:agent-core dependency on agent-interface declares ^3.0.0, which does not admit installed 2.16.0. Agent Core 0.10.3, published 2026-10-06 07:00Z, requires Interface 3 inside Eval 0.208.2's^0.10.2range. That is an upstream cohort break, not this change.