Repository navigation
refactor(memory)!: remove the unused memory experiment, improvement, and benchmark runners - #241
Merged
Conversation
…and benchmark runners Nothing outside this repository imports runAgentMemoryExperiment, runAgentMemoryLearningExperiment, runAgentMemoryImprovement, runKnowledgeBenchmarkSuite, or runMemoryAdapterBenchmark. They duplicated experiment and improvement machinery that Agent Eval owns. Memory adapters, branches, holdout, lifecycle bounds, play memory tools, and the benchmark adapters Supervisor Lab imports stay. BREAKING CHANGE: the memory experiment, memory improvement, and benchmark suite exports are removed.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
tangletools
approved these changes
Oct 6, 2026
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved PR — 4d4c0650
Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-06T07:10:47Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
/memoryand/benchmarkscarried a second experiment and improvement engine: matched-arm learning experiments,runAgentMemoryImprovementwith run leases, cost meters, and activation, and a benchmark suite with industry smoke catalogs, qrels import, scoring, and memory recovery runners. That is 9,545 source lines and 5,746 test lines. Nothing outside this repository imports any of it. Agent Eval already owns shared experiment and improvement machinery (AGENTS.md: "shared evaluation and improvement machinery belongs toagent-eval").Change
src/memory/experiment/,src/memory/improvement/, their barrels,memory/run-control.ts,memory/attempt-log.ts,candidate-ranking.ts, and everysrc/benchmarks/module exceptadapters.ts.tests/memory/experiment-*,tests/memory/improvement.test.ts,tests/benchmarks/, the support helpers, and the improvement-candidate cases in the Mem0 and Graphiti tests./benchmarksnow exports onlycreateInMemoryBenchmarkAdapterandcreateNoopMemoryBenchmarkAdapter. Supervisor Lab imports both.verify-package.mjscheckscreateAgentMemoryBranchon/memoryin place ofrunAgentMemoryImprovement.Kept: memory adapters (Mem0, Neo4j, Graphiti, Hindsight), branches, retrieval holdout,
runBoundedMemoryLifecycleand its errors (Hindsight uses them), play memory tools, schemas, and source records.Consumer evidence
The same scan as #240: identifiers imported from the package, including
/memoryand/benchmarkssubpaths and dynamic imports. It covered the Mac~/webband~/companytrees,~/codeon beelink1 and drew-gtr-pro, and fresh default-branch clones of the 22 repositories that depend on the package, plus discovery, agent-eval, agent-sdk, and braid. None of the removed names is imported./memoryimports in use: Agent Runtime (AgentMemoryAdapter, branch and snapshot APIs,createPlayMemoryTools,defaultGetMemoryContext), Blueprint Agent and Supervisor Lab (memory types, holdout,renderMemoryContext)./benchmarksimports in use: Supervisor Lab'sarchive/bench/memory(the two adapters). All of these stay.Why this is the right long-term shape
Knowledge keeps the memory contract and provider adapters. Experiments, comparison, and promotion decisions run in Agent Eval, which has one maintained implementation.
Cost
69 files, 11 insertions, 15,568 deletions. This rides the unpublished 20.0.0 major from #240 (latest published is 19.1.5), so it adds no second major. Risk: an unlisted private caller of the removed runners. Rollback: revert, or stay on 19.x.
Verification (beelink1, merged with origin/main)
pnpm install --frozen-lockfile,pnpm lint(only the existingproposals.tswarning),pnpm typecheck(source and contracts),pnpm build, andpnpm run api:surface(740 exports) all pass.pnpm testwith network tests: 72 files, 754 passed, 2 skipped, 0 failed.node scripts/check-version-bump.mjspasses: 210 export changes are paid for by 19.1.5 -> 20.0.0.git merge-tree --write-tree origin/main HEADis clean.verify:packageis still blocked upstream for main and this branch alike: Agent Core 0.10.3 requires Interface 3 (see refactor(research)!: remove the unused web research drivers and TCloud #240).