Repository navigation
refactor(sources)!: remove the unused authority source adapters, change detection, and freshness stores - #242
Merged
Conversation
…ge detection, and freshness stores No consumer imports the /sources entry point, its Cornell LII, IRS, and state Secretary of State adapters, politeFetch, htmlToText, detectChanges, or the freshness stores. The source registry and readiness freshness scoring stay. CI no longer sets AGENT_KNOWLEDGE_RUN_NETWORK_TESTS, which only the deleted live source test read. BREAKING CHANGE: the ./sources entry point and the change-detection and freshness-store exports are removed.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
tangletools
approved these changes
Oct 6, 2026
tangletools
left a comment
tangletools
left a comment
Contributor
There was a problem hiding this comment.
✅ Auto-approved PR — bd405db1
Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-06T07:13:46Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
/sourcesentry point (also re-exported from the root) shipped three authority adapters from #7 (2026-05-14): Cornell LII, IRS publications, and state Secretary of State. They came with a polite HTTP fetcher with an on-disk cache, HTML extraction,detectChanges, and filesystem and D1-stub freshness stores. Nothing outside this repository imports any of it. Its only in-repo user, the web research worker, was removed in #240. That leaves 1,471 source lines and 984 test lines, including a live-network test that CI enabled throughAGENT_KNOWLEDGE_RUN_NETWORK_TESTS.Change
src/sources/,src/changes.ts,src/freshness.ts, and their tests (sources-types,sources-mocked,sources-live,http-cache,changes,freshness)../sourcesexport, its tsdown entry, its packed-import check, and its README rows.AGENT_KNOWLEDGE_RUN_NETWORK_TESTSin CI. Only the deleted live test read it.Kept: the source registry (
addSourceText,addSourcePath,loadSourceRegistry,src/sources.ts),SourceAdapterandtextSourceAdapter(Agent App imports them), and source freshness in readiness and inspection.Consumer evidence
The same scan as #240 and #241 found no import of
@tangle-network/agent-knowledge/sources, and no root import of any removed name (createCornellLiiSource,createIrsPublicationsSource,createStateSosSource,politeFetch,htmlToText,extractLinks,looksLikeBlockPage,detectChanges,createFileSystemFreshnessStore,createD1FreshnessStoreStub,KnowledgeSource, and the rest). The only textual matches are Supervisor Lab'sarchive/bench/memory/integrations.ts, which names the adapters in prose strings, and a delivery copy of a ph0ny file, which defines its ownKnowledgeSource.Why this is the right long-term shape
Domain authority connectors belong to the products that need them. Knowledge keeps the registry they write into.
Cost
23 files, 2 insertions, 2,532 deletions. This rides the unpublished 20.0.0 major. Rollback: revert, or stay on 19.x.
Verification (beelink1, merged with origin/main)
pnpm install --frozen-lockfile,pnpm lint(only the existingproposals.tswarning),pnpm typecheck,pnpm build, andpnpm run api:surface(676 exports across 5 entry points) all pass.pnpm test: 66 files, 695 passed, 2 skipped, 0 failed.node scripts/check-version-bump.mjspasses: 1 manifest change and 64 export changes are paid for by 19.1.5 -> 20.0.0.git merge-tree --write-tree origin/main HEADis clean.