Repository navigation
build(deps): bump minimatch from 10.2.5 to 11.0.1 - #495
Conversation
Bumps [minimatch](https://github.com/isaacs/minimatch) from 10.2.5 to 11.0.1. - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v10.2.5...v11.0.1) --- updated-dependencies: - dependency-name: minimatch dependency-version: 11.0.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
|
@SocketSecurity ignore-all |
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. Because it's a major-version bump of a runtime dependency that rewrites how matching works and adds a new transitive package, a maintainer should still take a look.
What was reviewed:
- The minimatch call sites in src/asar.ts (lines 2, 28, 159) and benchmark/profile-pack.ts. They use the named
minimatchimport and thematchBaseoption. The v11 changelog removes neither, and the code doesn't use any of the removed APIs (makeRe,regexp,AST,debug,matchOne). - The v11 behavior changes that could still affect the
--unpack/--unpack-dirglobs: matching now usesMatcherobjects instead of RegExp,a/b/no longer matches?(x)/*(x), and Windows UNC and..handling changed. - yarn.lock: the new
@ isaacs/nonrecursive-glob-match@ 1.0.3entry and the merged brace-expansion 5.0.12 range. minimatch 10.2.5 stays in the lockfile for glob.
Extended reasoning...
The change bumps the runtime dependency minimatch from ^10.0.1 to ^11.0.1 in package.json and updates yarn.lock to match. No source files change. Through the new minimatch, the lockfile adds @ isaacs/nonrecursive-glob-match@ 1.0.3, a package new to this repository, which is a supply-chain surface worth a human check. I didn't approve for three reasons: v11 replaces the matching engine behind asar's unpack globs, the repo's CODEOWNERS file assigns every path to a code-owner team, and node_modules isn't installed in this checkout, so I couldn't run the tests against v11.
Resolve conflicts after dependabot's minimatch 11.0.1 bump (#495): keep glob ^14.0.3 on top of main's minimatch ^11.0.1, and regenerate yarn.lock from main's version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WB5GaFQJxRHH5bzvuTCziJ
Bumps minimatch from 10.2.5 to 11.0.1.
Changelog
Sourced from minimatch's changelog.
... (truncated)
Commits
47afe8811.0.177a0f5climit **/.. optimization pass to avoid quadratic explosion6f9f13111.0.002dcbe4update oxlint47b5d1ahandle //?/UNC/host/share long UNC forms05bce27do not optimize out the windows rootba01806document that a / takes priority over extglob sectionse5c04b4correct 'partial' mode matching of multiple-** patternscff11d8compare UNC host/share case-insensitivelyc86670ebenchmark scriptsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.