Repository navigation
build(deps): bump glob from 13.0.6 to 14.0.2 - #494
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
|
@SocketSecurity ignore-all |
| }, | ||
| "dependencies": { | ||
| "glob": "^13.0.2", | ||
| "glob": "^14.0.2", |
There was a problem hiding this comment.
🟡 (optional) Consumers passing globOptions to createPackageWithOptions get glob 14's breaking behavior and types in what ships as a non-major asar release. The globOptions field (src/asar.ts:47) is glob's own GlobOptionsWithFileTypesFalse, and src/crawlfs.ts:32 forwards it unchanged. So glob 14 drops debug, re-roots ignore patterns starting with /, applies windowsPathsNoEscape: true to ignore, and changes matching to minimatch 11. Fix: publish this as a breaking asar release (e.g. a !/BREAKING CHANGE commit), or keep glob ^13 until a planned major.
Why this was flagged
An asar API caller such as electron-builder or Forge passes globOptions: { ignore: [...] } or debug through createPackageWithOptions. src/asar.ts:63-68 hands them to crawlFilesystem, and src/crawlfs.ts:32-35 spreads them into glob() after windowsPathsNoEscape: true. With glob 14, backslash-escaped ignore entries are now read as path separators on Windows. ignore entries starting with / now resolve against root, and debug is a TypeScript error. Files the caller excluded on 13.0.6 can now end up in the archive, or included files can drop out. The release workflow (.github/workflows/release.yml) runs semantic-release, and a build(deps): commit does not cut a major version, so ^ ranges in downstream projects pick this up automatically. No source change or test adapts or documents the new semantics.
Verification: Trigger: a programmatic asar caller passes globOptions. crawl spreads it into glob(dir, { windowsPathsNoEscape: true, ...options }) (src/crawlfs.ts:32-35). The diff changes "glob": "^13.0.2" to "^14.0.2". This commit is typed build(deps): with no breaking marker. The result is that consumers' ignore sets can silently include or exclude different files, all without a major bump.
Bumps [glob](https://github.com/isaacs/node-glob) from 13.0.6 to 14.0.2. - [Changelog](https://github.com/isaacs/node-glob/blob/main/changelog.md) - [Commits](isaacs/node-glob@v13.0.6...v14.0.2) --- updated-dependencies: - dependency-name: glob dependency-version: 14.0.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
c86a07d to
c6995b4
Compare
|
@MarshallOfSound any chance for a release containing this and #495 to resolve the minimatch security vulnerabilities? this is also awaited by electron-builder. |
Bumps glob from 13.0.6 to 14.0.2.
Changelog
Sourced from glob's changelog.
... (truncated)
Commits
93957bf14.0.24682e8cfix: do not continue walking after signal abort668a66914.0.16ff2314allow const/readonly string[] for ignore, patternsbbe1e5d14.0.0d9586aduse actual published deps, not symlinks8b16637handle long unc forms5bcdc65extglobs cannot contain /d8b40c2handle root in platform-independent way, for ignores and patterns7d1c45aadd native fs glob test (todo on failure)