Repository navigation
fix(deps): bump glob to ^14.0.3 - #492
claude[bot] wants to merge 2 commits into
Conversation
minimatch 11.0.1 is the first release patched for GHSA-g3hv-75wg-m249. glob 14.0.3 depends on minimatch ^11.0.2, so asar's runtime tree no longer contains any minimatch 10.x. The glob() and minimatch() call sites and the GlobOptionsWithFileTypesFalse type are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WB5GaFQJxRHH5bzvuTCziJ
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution Review the following alerts detected in dependencies. According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. It is recommended to resolve "Warn" alerts too. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
I reviewed this PR and didn't find any bugs. It's still worth a human look: it moves two runtime dependencies up a major version and adds a new transitive package, @ isaacs/nonrecursive-glob-match. The lockfile was also resolved with the 7-day npmMinimalAgeGate turned off, so a maintainer should sign off on taking releases this new.
What was reviewed:
- The package.json ranges and the yarn.lock changes. glob 14.0.3 now pulls in minimatch ^11.0.2 and path-scurry ^3.0.0. minimatch 10.2.5 stays in the lockfile only for the ^10.2.4 range.
- The places where the source uses these packages:
minimatchandGlobOptionsWithFileTypesFalsein src/asar.ts, andglobin src/crawlfs.ts. This is a small API surface, but I couldn't confirm the new versions' engine fields here against the project's>=22.12.0requirement.
Extended reasoning...
The change touches only package.json and yarn.lock. It bumps glob from ^13 to ^14 and minimatch from ^10 to ^11, which also brings in path-scurry 3 and a new transitive package. No auth or crypto code changes, but this is a dependency and supply-chain change. The versions are only a few days old, and the PR says they were resolved with the repository's minimum-age gate turned off. All files are covered by a CODEOWNERS entry, so I deferred to a maintainer instead of approving.
Resolve conflicts after dependabot's minimatch 11.0.1 bump (#495): keep glob ^14.0.3 on top of main's minimatch ^11.0.1, and regenerate yarn.lock from main's version. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WB5GaFQJxRHH5bzvuTCziJ
|
Superseded by #495 (minimatch ^11.0.1) and #494 (glob ^14.0.2), which leave asar's runtime tree on minimatch 11.x only. Closing. Note that Generated by Claude Code |
Requested by Mike Maietta · Slack thread
mainalready tookminimatch^11.0.1in #495, butglob13 still pulls in minimatch 10.2.5 at runtime, and GHSA-g3hv-75wg-m249 is only patched in minimatch 11.0.1 and later. glob 14.0.3 is the first glob release on minimatch^11.0.2, so with this bump from^13.0.2to^14.0.3asar's runtime tree has only minimatch 11.x, which clears the alert electron-builder users see through asar (electron-userland/electron-builder#10537). One caveat: glob 14.0.3 and path-scurry 3.0.0 are less than 7 days old, younger than thenpmMinimalAgeGatein.yarnrc.yml, so I resolved the lockfile once with the gate off;yarn install --immutablepasses with it on.Generated by Claude Code