Repository navigation
ci: run the browser Playwright suite - #99
Merged
frontegg-david merged 1 commit intoOct 4, 2026
Merged
Conversation
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 17 minutes. View limit detailsLimit details: You’ve used all 3 included reviews currently available. Your 43 included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Comment |
This was referenced Oct 4, 2026
frontegg-david
added this pull request to stack #97
October 4, 2026 00:10
alexmercerpo
approved these changes
Oct 4, 2026
@enclave-vm/browser is tested only by its Playwright e2e suite (nx run browser:test-e2e), which CI never ran: the Test job runs the jest targets. New Browser E2E job, after Build like the Test job: it restores node_modules from the build cache, asks nx which projects with a test-e2e target are affected (today only browser, and through it ast), and when there is one, installs Chromium (browsers cached per Playwright version) and runs nx affected -t test-e2e. On failure it uploads the HTML report and traces. On CI the Playwright config forbids test.only, retries a failed test once (the timeout specs measure real time; a retried pass is still reported as flaky), adds the GitHub reporter for annotations, and keeps a trace of each failure. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
frontegg-david
force-pushed
the
ci/browser-e2e-playwright
branch
from
October 4, 2026 00:23
6133c26 to
495e5af
Compare
This was referenced Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 7/10:
main← #92 ← #93 ← #94 ← #95 ← #96 ← #98 ← this ← #100 ← #101 ← #102@enclave-vm/browseris tested only by its Playwright e2e suite (nx run browser:test-e2e, now 83 tests across this stack), and CI never ran it: the Test job runs the jest targets only. Every browser change in #92–#95 was verified locally only.Change
New
Browser E2Ejob in.github/workflows/push.yml, after Build, set up like the Test job. It:node_modulesfrom the build cache and runsyarn install --immutable;test-e2etarget (nx show projects --affected --withTarget test-e2e). Today that's onlybrowser, whichastchanges also affect. With none, the remaining steps are skipped and no browser is downloaded;playwright install --with-deps chromium), caching~/.cache/ms-playwrightper Playwright version; on a cache hit it only installs the system dependencies;nx affected -t test-e2e;playwright-report, 14 days).The Playwright suite builds its own bundle from source (
e2e/build-test-bundle.mjs), so it doesn't depend onlibs/*/dist.serve, which the suite's web server uses, is already a devDependency.libs/browser/playwright.config.ts, CI only (local runs are unchanged):forbidOnly;Verification
Affected e2e projects: browser, installed Chromium and reported83 passed (24.7s), with none flaky.CI=1 npx nx run browser:test-e2e: 83 passed, GitHub reporter notice printed, HTML report written (playwright-report/is gitignored).🤖 Generated with Claude Code