Repository navigation
chore(deps): update vulnerable transitive dependencies - #102
Conversation
Resolves the remaining 51 open Dependabot alerts (#101 handles the two on nx itself). All of them are transitive dependencies in yarn.lock. - yarn up -R moves each vulnerable package to the newest version its parents' ranges allow: undici, js-yaml, baseline-browser-mapping, svgo, qs, browserslist, fast-uri, @humanfs/node, postcss-selector-parser, postcss, brace-expansion, tar, body-parser, webpack-dev-server, shell-quote, immutable, websocket-driver, http-proxy-middleware and @babel/core. - The floors in "resolutions" left by earlier alert fixes (qs, immutable, shell-quote, svgo, fast-uri, webpack-dev-server) are raised to the patched versions, so a re-resolve cannot go back below them. - Scoped resolutions where a parent pins a vulnerable version exactly or allows no patched one: nx/brace-expansion ^5.0.9 (nx pins 5.0.8) and sockjs/uuid ^11.1.1 (sockjs, under webpack-dev-server, allows only ^8.3.2 and uuid has no patched 8.x; sockjs only calls require('uuid').v4, which uuid 11 still exports). Also fixes advisories yarn npm audit reports that Dependabot has not raised: axios 1.18.0 to 1.20.0 (several high), ajv 8.12.0 to 8.20.0 (serve/ajv, serve pins it exactly) and 6.12.6 to 6.15.0, smol-toml 1.6.1 to 1.9.0 (nx/smol-toml, nx pins it exactly). Still reported: braces 3.0.3, which has no patched release, and deprecation notices (eslint 9.39.2, glob 10.5.0, memfs 3.6.0, whatwg-encoding). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughThe ChangesDependency resolutions
Priority: ⬆️ High Estimated code review effort: 2 (Simple) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to No actionable compatibility issue introduced by this dependency update was established; the inspected SockJS API remains compatible. The PR is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Stack 10/10:
main← #92 ← #93 ← #94 ← #95 ← #96 ← #98 ← #99 ← #100 ← #101 ← thisDependabot, part 2 of 2. Together with the Nx update below this PR, it resolves all 53 open Dependabot alerts. Each alert's vulnerable range was checked with
semveragainst every version left inyarn.lock: 0 remain.Change
yarn up -Rmoves each vulnerable transitive package to the newest version its parents' ranges allow.resolutions. Earlier alert fixes left floors forqs,immutable,shell-quote,svgo,fast-uriandwebpack-dev-server; they now sit at the patched versions, so a future re-resolve can't drop below them.nx/brace-expansion: ^5.0.9: nx 22.7.12 pins 5.0.8; now 5.0.12 (patch level).sockjs/uuid: ^11.1.1: sockjs 0.3.24 (underwebpack-dev-server, dev only) allows only^8.3.2, and uuid has no patched 8.x. sockjs only callsrequire('uuid').v4(), which uuid 11 still exports; I checked it creates a server and generates ids. (The advisory concerns thebufargument of v3/v5/v6, which sockjs doesn't use.)serve/ajv: ^8.18.0andnx/smol-toml: ^1.7.1: see "Also fixed".undicijs-yamlbaseline-browser-mappingsvgoqsbrowserslistfast-uri@humanfs/nodepostcss-selector-parserpostcssbrace-expansiontarbody-parserwebpack-dev-servershell-quoteimmutablewebsocket-driverhttp-proxy-middleware@babel/coreuuid"Before" is
main's lockfile, with Nx 22.4.4.Also fixed (reported by
yarn npm audit, not yet raised by Dependabot)axios1.18.0 → 1.20.0 (several high: ReDoS, prototype-pollution gadgets, HTTP/2 DoS, proxy and redirect bypasses)ajv8.12.0 → 8.20.0 (serve/ajv; serve pins it exactly) and 6.12.6 → 6.15.0 (ReDoS with$data)smol-toml1.6.1 → 1.9.0 (nx/smol-toml; nx pins it exactly; DoS on malformed TOML)Still reported:
braces3.0.3 (high; no patched release exists yet), plus deprecation notices that aren't vulnerabilities (eslint9.39.2,glob10.5.0,memfs3.6.0,whatwg-encoding).Verification (after
nx reset)yarn lint,yarn format:check,yarn build(13 projects): passnx run-many -t test(10 projects), core jest (67 suites, 2376 passed), core perf (48 passed), browser e2e (90 passed; it runs onserve, so it covers the ajv change): pass🤖 Generated with Claude Code
Summary by CodeRabbit