Skip to content

feat(ping): add a locked Ping preset and optional direct bindings - #218

Draft
DEVLlN wants to merge 8 commits into
ThericGames:developfrom
DEVLlN:feat/reticle-ping-wheel
Draft

DEVLlN wants to merge 8 commits into
ThericGames:developfrom
DEVLlN:feat/reticle-ping-wheel

Conversation

@DEVLlN

@DEVLlN DEVLlN commented Nov 17, 2026 •

Copy link
Copy Markdown

Summary

Add a locked four-slice Ping preset to the existing Radial Menu. Players can add or remove the preset. It contains Attack, Warning, On My Way, and Assist.

Click Casting and wheel pings use the current mouseover or WoW's cursor hit test, so a soft target pinned by Target Lock cannot redirect them. Tapping with the cursor already on the reticle preserves its position. Releasing a slice after moving the cursor recenters it, and a timeout restores Mouse Look if the action is interrupted.

The optional direct bindings sit at the bottom of the Radial Menu tab. They use the same ping actions for tap and hold. The draft is open for feedback on retaining those bindings. It depends on #209 for the opt-in Blizzard Ping cursor unlock.

Validation

  • Repository checks, globals, lint, and LuaJIT load/spec tests passed across eight client configurations.
  • Tests cover cursor-based routing, centered taps, recentering after a flick, the locked preset, input rebinding, and Mouse Look recovery.
  • The user confirmed the Target Lock targeting fix in their local Forever build.
  • In-game testing of the draft on Retail, Forever, and Classic, including all four slices, cancellation, combat, and the other wheels.

@sampconrad

Copy link
Copy Markdown
Collaborator

Thanks for this, @DEVLlN, and for being clear that it's still a draft. The wheel and the reticle-aimed ground ping are a good idea. I'd like to change the shape before it goes further.

Direction

  1. Make this a locked preset in the Radial Menu, not a new tab. The PR already registers pingattack, pingwarning, pingonmyway and pingassist as radial actions. A Ping preset with those four slices would use the existing Radial key, secure wheel, renderer and editor. A player could add or delete it like any other wheel, but couldn't edit its slots. A locked flag on the wheel would do that, with the editor disabling slot changes, add or remove slice, and reordering. That drops the new tab, the two Bindings.xml entries, the duplicated secure snippet, the Party Wheel and Radial edits, and the locationPing hiding in the editor. What stays is the Mouse Look bounce, as a hook in the radial action's click path.
  2. Reconcile this with feat(freelook): add cursor aiming for the Blizzard Ping binding #209. That PR solves the same problem (aiming a ground ping from Mouse Look) by freeing the real cursor for Blizzard's native Ping. Both PRs edit the same two lines of FreeLookController.lua (IsGroundTargeting() or ...), each with its own flag. The mechanisms also exclude each other on one key: this PR binds the key to its own click button, and feat(freelook): add cursor aiming for the Blizzard Ping binding #209 only fires when the key resolves to TOGGLEPINGLISTENER. Please say which approach you want, so we don't carry two.
  3. Click Casting already has Ping actions. develop has Ping, Ping: Attack, Warning, On My Way and Assist in the "Modified Blizzard Actions" list, using /ping [@mouseover,exists] <n>. They cover quick tap pings, so the tap behaviour doesn't need a second path.

Needs fixing either way

  • CM.locationPingActive can get stuck. It is set in PreClick and only cleared by a C_Timer.After(0) scheduled from PostClick. If the click is dropped or errors, Mouse Look stays unlocked and LockFreeLook returns early. Please also clear it from the wheel's OnHide or after a short timeout.
  • Translations. The new strings are English fallbacks in all ten locale files. Please add drafted translations, as the repo requires.
  • Docs and headers. Please update the headers to the required format (Path/File.lua — DOMAIN — title, then What it does / Architecture / Does not / Related) and the matching domain-radial-menu.md note. If a new file stays, STRUCTURE.md needs it too.
  • Tests. The spec only checks that the actions exist. Please add what can be tested without a live client, such as the locked-preset behaviour, if it moves to a preset.

Before this leaves draft

  • Please do the in-game checks from your list: Retail, Forever and Classic, combat, all four slices on units and on ground, cancel with Esc and right-click, Mouse Look restoration, and interaction with the other wheels.
  • Run pwsh ./scripts/lint-changed.ps1 twice.

@DEVLlN DEVLlN changed the title feat(ping): add dedicated reticle ping menu and bindings feat(ping): add a locked Ping preset and optional direct bindings Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants