Repository navigation
Conversation
Collaborator
|
Please, close the other PRs related to this so we only have a single one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish the editable Ping wheel tested locally in WoW Forever. Ping starts with the four standard pings. Its editor accepts pings, target and world markers, Ready Check, Pull Countdown, and Role Check. Players can add, change, remove, and reorder slices.
With Separate Ping Wheel enabled, the same wheel appears below its single optional keybind at the bottom of the Radial Menu tab. An active dedicated key removes Ping from the shared rotation. Turning the option off restores the saved wheel to the shared editor and rotation. Target marker slices prefer the unit aimed at and can mark an unselected unit. Pings preserve Target Lock.
This draft replaces #221 and builds on #218, which includes #209. It proposes editability and the optional dedicated binding for review while retaining the existing Radial Menu editor and renderer.
Editable Ping changes only
Validation