Skip to content

feat(ping): make the Ping wheel editable - #222

Closed
DEVLlN wants to merge 9 commits into
ThericGames:developfrom
DEVLlN:feat/editable-ping-wheel
Closed

DEVLlN wants to merge 9 commits into
ThericGames:developfrom
DEVLlN:feat/editable-ping-wheel

Conversation

@DEVLlN

@DEVLlN DEVLlN commented Nov 21, 2026

Copy link
Copy Markdown

Summary

Publish the editable Ping wheel tested locally in WoW Forever. Ping starts with the four standard pings. Its editor accepts pings, target and world markers, Ready Check, Pull Countdown, and Role Check. Players can add, change, remove, and reorder slices.

With Separate Ping Wheel enabled, the same wheel appears below its single optional keybind at the bottom of the Radial Menu tab. An active dedicated key removes Ping from the shared rotation. Turning the option off restores the saved wheel to the shared editor and rotation. Target marker slices prefer the unit aimed at and can mark an unselected unit. Pings preserve Target Lock.

This draft replaces #221 and builds on #218, which includes #209. It proposes editability and the optional dedicated binding for review while retaining the existing Radial Menu editor and renderer.

Editable Ping changes only

Validation

  • Compared the wheel and editor modules, ping macros, and dedicated binding with the installed Forever build. The implementation matches after formatting and removing an unused local.
  • Ran changed-file lint twice. Repository, globals, and LuaJIT tests passed across eight client configurations.
  • Specs cover the toggle, binding retention, slice editing, the command allowlist, target marking, and cursor cleanup.
  • Full live validation on Retail and Classic, plus the remaining Forever checks for combat, cancel and mouse-look restoration, and interaction with the other wheels.

@sampconrad

Copy link
Copy Markdown
Collaborator

Please, close the other PRs related to this so we only have a single one.

@sampconrad sampconrad closed this Nov 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants