Skip to content

feat(freelook): add cursor aiming for the Blizzard Ping binding - #209

Open
DEVLlN wants to merge 2 commits into
ThericGames:developfrom
DEVLlN:feat/optional-ping-cursor
Open

DEVLlN wants to merge 2 commits into
ThericGames:developfrom
DEVLlN:feat/optional-ping-cursor

Conversation

@DEVLlN

@DEVLlN DEVLlN commented Nov 13, 2026 •

Copy link
Copy Markdown

Summary

Adds Auto Unlock → Unlock Cursor for Ping, off by default. Hold either key assigned to Blizzard's Ping action to aim with the cursor, then release it to resume Mouse Look. It follows live rebindings, supports mouse and keyboard bindings with modifiers, and honors Combat Mode overrides on the same key.

This is for the native Blizzard Ping workflow. #218 offers a reticle-aimed Radial Menu preset and optional direct bindings. Each key runs the action currently bound to it.

Validation

  • Updated from develop, restored UTF-8 translations, and regenerated the in-game changelog.
  • LuaJIT load/spec suite across eight client configurations. Coverage includes middle mouse, a side button, keyboard, the second binding, modifiers, and release while another unlock condition is active.
  • Ran lint-changed.ps1 twice. Final pass is clean.
  • In-game Retail, Forever and Classic checks for tap/hold, rebinding, release, and combat transitions.

@sampconrad sampconrad left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @DEVLlN. The feature is opt-in and the spec is solid. A few things need fixing before merge.

Blocking

  1. It should follow whatever key Ping is bound to, not just middle mouse. IsMiddleMousePingHeld() hard-codes BUTTON3, so Ping on a side button or a keyboard key gets nothing. Read the bound keys with GetBindingKey("TOGGLEPINGLISTENER") (up to two, possibly with modifiers). Treat Ping as held when a base key is down and its modifiers match. Use IsMouseButtonDown for mouse buttons and IsKeyDown for the rest. Then drop "middle mouse" from the option name, tooltip, changelog and rule note, and extend the spec to cover a keyboard key, Button4, the second binding slot and modifiers.
  2. The new locale strings are corrupted. Accented and non-Latin characters became literal ? in all ten translated files. Examples are Cursor f?r Ping freigeben, and koKR, ruRU, zhCN and zhTW are entirely question marks. Please re-write them as UTF-8. check-repo only checks that the keys exist, so it won't catch this.
  3. The branch conflicts with develop. After resolving, regenerate ChangelogData.lua with pwsh ./scripts/sync-changelog-to-lua.ps1 instead of merging it by hand.

Before merge

  • Please do the in-game checks from your test plan: Ping on middle mouse, a side button and a keyboard key, tap versus hold, release behaviour and combat transitions.
  • Run pwsh ./scripts/lint-changed.ps1 twice once the conflicts are resolved.
  • Please test on Retail, Forever and Classic and check that the unlock works with no Lua errors.

@DEVLlN DEVLlN changed the title feat(freelook): add optional cursor aiming for middle-mouse ping feat(freelook): add cursor aiming for the Blizzard Ping binding Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants