Repository navigation
Conversation
sampconrad
self-requested a review
November 14, 2026 03:07
sampconrad
requested changes
Nov 19, 2026
Collaborator
There was a problem hiding this comment.
Thanks for this, @DEVLlN. The feature is opt-in and the spec is solid. A few things need fixing before merge.
Blocking
- It should follow whatever key Ping is bound to, not just middle mouse.
IsMiddleMousePingHeld()hard-codesBUTTON3, so Ping on a side button or a keyboard key gets nothing. Read the bound keys withGetBindingKey("TOGGLEPINGLISTENER")(up to two, possibly with modifiers). Treat Ping as held when a base key is down and its modifiers match. UseIsMouseButtonDownfor mouse buttons andIsKeyDownfor the rest. Then drop "middle mouse" from the option name, tooltip, changelog and rule note, and extend the spec to cover a keyboard key, Button4, the second binding slot and modifiers. - The new locale strings are corrupted. Accented and non-Latin characters became literal
?in all ten translated files. Examples areCursor f?r Ping freigeben, and koKR, ruRU, zhCN and zhTW are entirely question marks. Please re-write them as UTF-8.check-repoonly checks that the keys exist, so it won't catch this. - The branch conflicts with
develop. After resolving, regenerateChangelogData.luawithpwsh ./scripts/sync-changelog-to-lua.ps1instead of merging it by hand.
Before merge
- Please do the in-game checks from your test plan: Ping on middle mouse, a side button and a keyboard key, tap versus hold, release behaviour and combat transitions.
- Run
pwsh ./scripts/lint-changed.ps1twice once the conflicts are resolved. - Please test on Retail, Forever and Classic and check that the unlock works with no Lua errors.
3 of 4 tasks
This was referenced Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Auto Unlock → Unlock Cursor for Ping, off by default. Hold either key assigned to Blizzard's Ping action to aim with the cursor, then release it to resume Mouse Look. It follows live rebindings, supports mouse and keyboard bindings with modifiers, and honors Combat Mode overrides on the same key.
This is for the native Blizzard Ping workflow. #218 offers a reticle-aimed Radial Menu preset and optional direct bindings. Each key runs the action currently bound to it.
Validation
develop, restored UTF-8 translations, and regenerated the in-game changelog.lint-changed.ps1twice. Final pass is clean.