Repository navigation
Error when PGXNTOOL_ENABLE_TEST_INSTALL=yes but test/install/ is empty - #131
Merged
jnasbyupgrade merged 4 commits intoOct 7, 2026
Conversation
Setting `PGXNTOOL_ENABLE_TEST_INSTALL=yes` is documented to error when `test/install/` has no SQL files, the same way `PGXNTOOL_ENABLE_TEST_BUILD=yes` does for `test/build/`. Instead the schedule was generated with no entries and `make test` silently ran no install files. The `test/install/schedule` recipe now fails with `ERROR: no .sql files found in test/install/` before writing the schedule. The check lives in the recipe rather than at parse time, so targets that never run the tests (`clean`, `dist`, ...) keep working with the variable set. Related changes in pgxntool-test: - Test that `make test/install/schedule PGXNTOOL_ENABLE_TEST_INSTALL=yes` fails on an empty `test/install/` and writes no schedule, while `make -n dist` and `make clean` still succeed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…t/install SQL files Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool-test
that referenced
this pull request
Oct 7, 2026
…#98) Adds coverage for Postgres-Extensions/pgxntool#131: `PGXNTOOL_ENABLE_TEST_INSTALL=yes` must error when `test/install/` has no SQL files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related pgxntool-test PR: Postgres-Extensions/pgxntool-test#98
PGXNTOOL_ENABLE_TEST_INSTALL=yesnow fails whentest/install/has no SQL files, and the failure happens at parse time, so any make target errors until SQL files are present or the variable is unset.The check is an
ifeqinside theifdef PGXNTOOL_ENABLE_TEST_INSTALLblock ofbase.mk, so make raisesno .sql files found in $(TESTDIR)/install/ (PGXNTOOL_ENABLE_TEST_INSTALL=yes)while reading the Makefile.Merge order: merge this PR first, then the pgxntool-test PR. This PR adds behavior and the pgxntool-test PR adds coverage for it, so the coverage would fail against pgxntool master if it landed first.
🤖 Generated with Claude Code