Skip to content

Error when PGXNTOOL_ENABLE_TEST_INSTALL=yes but test/install/ is empty #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnasbyupgrade merged 4 commits into from
Oct 7, 2026
Merged

Error when PGXNTOOL_ENABLE_TEST_INSTALL=yes but test/install/ is empty #131

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29e2ae4
Error when PGXNTOOL_ENABLE_TEST_INSTALL=yes but test/install/ is empty
jnasbyupgrade Oct 7, 2026
d8797c5
Merge remote-tracking branch 'upstream/master' into pre-2.4.0-test-in…
jnasbyupgrade Oct 7, 2026
bd5aa7d
HISTORY: drop test/install empty-dir entry
jnasbyupgrade Oct 7, 2026
2e8f4d0
Error at parse time when PGXNTOOL_ENABLE_TEST_INSTALL=yes with no tes…
jnasbyupgrade Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions base.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,9 @@ ifdef PGXNTOOL_ENABLE_TEST_INSTALL
# override needed so command-line values (make VAR=YES) are normalized, not silently ignored.
# := needed for immediate evaluation of the function call (avoids infinite recursion with =).
override PGXNTOOL_ENABLE_TEST_INSTALL := $(call pgxntool_validate_yesno,$(PGXNTOOL_ENABLE_TEST_INSTALL),PGXNTOOL_ENABLE_TEST_INSTALL)
ifeq ($(PGXNTOOL_ENABLE_TEST_INSTALL)$(strip $(TEST_INSTALL_SQL_FILES)),yes)
$(error no .sql files found in $(TESTDIR)/install/ (PGXNTOOL_ENABLE_TEST_INSTALL=yes))
endif
else
Comment thread
jnasbyupgrade marked this conversation as resolved.
# Auto-detect: enable if test/install/ directory has SQL files
ifneq ($(strip $(TEST_INSTALL_SQL_FILES)),)
Expand Down
Loading