Repository navigation
Test PGXNTOOL_ENABLE_TEST_INSTALL=yes erroring on empty test/install/ - #98
Merged
jnasbyupgrade merged 3 commits intoOct 7, 2026
Conversation
Add tests for pgxntool commit 29e2ae4 (error when `PGXNTOOL_ENABLE_TEST_INSTALL=yes` but `test/install/` is empty): - `test/install/schedule` recipe fails with `no .sql files found in test/install/` and writes no schedule New `test-test-install.bats` test runs on the empty-`test/install/` state the preceding test leaves behind: asserts the schedule target fails with that message, and that `make -n dist` and `make clean` still succeed with the variable set (no parse-time error). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool
that referenced
this pull request
Oct 7, 2026
#131) Related pgxntool-test PR: Postgres-Extensions/pgxntool-test#98 `PGXNTOOL_ENABLE_TEST_INSTALL=yes` now fails when `test/install/` has no SQL files, and the failure happens at parse time, so any make target errors until SQL files are present or the variable is unset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds coverage for Postgres-Extensions/pgxntool#131:
PGXNTOOL_ENABLE_TEST_INSTALL=yesmust error whentest/install/has no SQL files.The new
test-test-install.batstest reuses the empty-test/install/state that the previous test leaves behind. It checks thatmake test/install/schedule PGXNTOOL_ENABLE_TEST_INSTALL=yesfails withno .sql files found in test/install/and writes no schedule.Merge order: merge Postgres-Extensions/pgxntool#131 first. This PR's new test fails against pgxntool master until that change is there.
🤖 Generated with Claude Code