Repository navigation
PCF parser to lazy-load particles to avoid loading 700mb of vram + fix map pacs - #1478
Merged
Merged
Conversation
…azy load pcf particles Co-authored-by: Python1320 <python1320@users.noreply.github.com>
thegrb93
requested changes
Oct 22, 2026
thegrb93
reviewed
Oct 22, 2026
thegrb93
requested changes
Oct 22, 2026
thegrb93
reviewed
Oct 22, 2026
Collaborator
Author
|
Haven't had the time to look into it yet, traveling. |
thegrb93
approved these changes
Oct 25, 2026
thegrb93
left a comment
thegrb93
left a comment
Collaborator
There was a problem hiding this comment.
I think changes are good if you could test and be sure whenever you're available again.
Author
|
So i've double checked everything on particle casing, and yeah everything is case insensitive, also fixed a slight bug in the parser |
thegrb93
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resumes the work of @Python1320 in #1464
It helps reduce pac's VRAM usage by about ~700mb, this is primarily due to the fact that pac loads all tf2 effects regardless of whether they're being used.
This PR introduces a small .pfc parser that will retrieve the name of the used effects and load the corresponding file only when needed. As a side bonus it also fixes the
pac_spawn_mapfeature that seemed to be broken since 2013.