Skip to content

Round fractional seconds instead of truncating #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremander wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Round fractional seconds instead of truncating #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pytimeparse/tests/testtimeparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ def test_fractional_units_exact_integer_results(self):
("0.41w", 247968),
("4.1 minutes", 246),
("4.1h30s", 14790),
("1.33333h", 4799),
("1.33333h", 4800),
("0.33333d", 28800),
("0.3333333333333333d", 28800),
]
for text, expected in cases:
for prefix, sign in [("", 1), ("+", 1), ("-", -1)]:
Expand Down
2 changes: 1 addition & 1 deletion pytimeparse/timeparse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def timeparse(sval: str, granularity: str = "seconds") -> Optional[Union[int, fl
return sign * (
# sum exactly so that values such as '4.1m' are
# not truncated one second short by float error
int(
round(
sum(
[
MULTIPLIERS[k] * Decimal(v)
Expand Down