Repository navigation
Round fractional seconds instead of truncating - #42
Open
jeremander wants to merge 1 commit into
Open
jeremander wants to merge 1 commit into
jeremander wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the update in #38 changed the output of
timeparse('0.3333333333333333 days')from 28800 to 28799. This is becauseDecimalis more precise thanfloat, so that numbers just shy of an integer are more likely to get truncated by theintcoercion.This change switches the behavior from truncation to rounding when fractional seconds occur, which should be more in line with user expectations.