Repository navigation
fix(files): contain artifact paths beneath root handles #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
07a7196
4307580
b65d3f5
e222627
fb30bc2
406d2be
5286cb6
0c339b5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,7 +17,8 @@ async-trait = "0.1" | |
| thiserror = "2" | ||
| anyhow = "1" | ||
| uuid = { version = "1", features = ["v4"] } | ||
| tokio = { version = "1", features = ["fs"] } | ||
| tokio = { version = "1", features = ["fs", "io-util", "rt"] } | ||
| cap-std = "4" | ||
|
Comment on lines
+20
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis
Add rationale comments for both The dependency guidelines require a comment above each newly added dependency entry that explains why the crate is needed and what uses it. Add comments above both The workspace uses Proposed fix
🤖 Prompt for AI Agents
Source: Coding guidelines There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The new AGENTS.md reference: AGENTS.md:L190-L191 Useful? React with 👍 / 👎. |
||
| tracing = "0.1" | ||
| tinytools = { git = "https://github.com/tinyhumansai/tinytools.git", rev = "3a01641", version = "0.6" } | ||
| # Artifact records and file bytes use the host-bound stable storage ports. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change enables Tokio's
io-utilfeature, but the rewritten filesystem implementation usesstd::io::{Read, Write}insidespawn_blocking, and a repository-wide search finds notokio::ioor async I/O extension usage. Thefsfeature coverscreate_dir_allandrtcoversspawn_blocking, soio-utilonly expands the enabled dependency surface and should be removed.AGENTS.md reference: AGENTS.md:L182-L184
Useful? React with 👍 / 👎.