Repository navigation
fix(a11y): restore keyboard focus when closing notices #8464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AmirrezaFarnamTaheri
wants to merge
8
commits into
tinyhumansai:main
Choose a base branch
from
AmirrezaFarnamTaheri:upstream/fix-notice-focus-lifecycle-20261027
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
80e05b4
test(a11y): cover notice panel focus entry and safe restoration
AmirrezaFarnamTaheri 5e19567
fix(a11y): restore focus after notice panel dismissal and closing
AmirrezaFarnamTaheri b4fa1ba
style(notices): remove extra blank line in focus regression tests
AmirrezaFarnamTaheri 82571be
style(notices): use concise test names to satisfy frontend Prettier c…
AmirrezaFarnamTaheri ade5861
style(notices): satisfy Prettier import layout for focus regression t…
AmirrezaFarnamTaheri da1e47e
test(a11y): preserve outside focus after a focused notice is removed
AmirrezaFarnamTaheri 6e45bad
fix(a11y): do not steal focus after focused notice unmounts
AmirrezaFarnamTaheri abdb5f1
fix(a11y): mount stable shell fallback for notice focus restoration
AmirrezaFarnamTaheri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.