Repository navigation
Conversation
examples/python is not covered by CI. .github/workflows/python-precommit.yml filters on examples/Python/** (capital P) but the directory is examples/python, and GitHub Actions path filters are case-sensitive, so the workflow has never run. The lint step also targeted application_examples examples, neither of which exists here. A follow-up PR fixes the workflow paths. This PR clears the pre-existing debt it will surface so that PR can turn CI on green. Split deliberately: the debt here is unrelated to the path bug, and this change is mechanical and independently reviewable. 7 files touched: - news-aggregator/main.py: E1205 x2 resolved to f-strings (logging-format-style=new per .pylintrc:396), black reformatted trailing whitespace/indentation at lines 51-53 - news-aggregator/main_sync.py: E1205 x2 resolved to f-strings - collect_paginated_ecommerce_listing_data/main.py: W1514 + W1309 on open(); black slice spacing - collect_paginated_news_headlines/main.py: W1514 on open() - compare_product_prices/async_main.py: black formatting (tuple unpacking, print collapse) - humanlike-antibot/main.py: isort import grouping - maps_scraper/main.py: isort import grouping Note: news-aggregator/main.py:45-47 and compare_product_prices/async_main.py:47-49 contain the same broken async with await browser.new_context() pattern as .templates/python/template_async.py:21-23. This PR reformats those lines without fixing the bug; that is left as a separate contribution.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughTwo Python examples now specify UTF-8 when opening output files. The news aggregators use f-strings for log messages, with their message text unchanged. Other edits reorder imports or adjust code formatting without changing the described behavior or output. Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The examples gain consistent UTF-8 output and formatting without an identified behavioral regression. This change is mergeable after normal checks; existing workflow-path and browser-context issues remain outside its scope. Architecture SummaryArchitecture risk: 🟡 Medium · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
Reliability and maintainability
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
examples/python is not covered by CI. .github/workflows/python-precommit.yml
filters on examples/Python/** (capital P) but the directory is examples/python, and GitHub Actions path filters are case-sensitive, so the workflow has never run. The lint step also targeted application_examples examples, neither of which exists here.
A follow-up PR fixes the workflow paths. This PR clears the pre-existing debt it will surface so that PR can turn CI on green. Split deliberately: the debt here is unrelated to the path bug, and this change is mechanical and independently reviewable.
7 files touched:
news-aggregator/main.py: E1205 x2 resolved to f-strings (logging-format-style=new per .pylintrc:396), black reformatted trailing whitespace/indentation at lines 51-53
news-aggregator/main_sync.py: E1205 x2 resolved to f-strings
collect_paginated_ecommerce_listing_data/main.py: W1514 + W1309 on open(); black slice spacing
collect_paginated_news_headlines/main.py: W1514 on open()
compare_product_prices/async_main.py: black formatting (tuple unpacking, print collapse)
humanlike-antibot/main.py: isort import grouping
maps_scraper/main.py: isort import grouping
Note: news-aggregator/main.py:45-47 and compare_product_prices/async_main.py:47-49 contain the same broken async with await browser.new_context() pattern as .templates/python/template_async.py:21-23. This PR reformats those lines without fixing the bug; that is left as a separate contribution.