Skip to content

fix(readme-enhance): captions cut at .NET / mid-word #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stuinfla wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(readme-enhance): captions cut at .NET / mid-word #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tools/readme-enhance.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,13 @@ const resolveIn = (buildDir, p) => (path.isAbsolute(p) ? p : path.resolve(buildD
function caption(alt, fallback) {
const t = String(alt || '').replace(/\s+/g, ' ').trim();
if (!t) return fallback;
const sentences = t.match(/[^.!?]+[.!?]+/g) || [t];
// Split on sentence-ending punctuation followed by whitespace, so ".NET", "v1.2" and "e.g." mid-sentence don't end a caption early.
const sentences = t.split(/(?<=[.!?])\s+/).filter(Boolean);
let out = '';
for (const s of sentences) { if ((out + s).length > 240) break; out += s; if (out.split(/[.!?]/).filter(Boolean).length >= 2) break; }
return (out || t.slice(0, 240)).trim();
for (const s of sentences) { if ((out + s).length > 240) break; out += (out ? ' ' : '') + s; if (out.split(/[.!?]/).filter(Boolean).length >= 2) break; }
if (out) return out.trim();
const cut = t.slice(0, 240); // one long sentence: break at a word, never mid-word
return `${cut.slice(0, Math.max(cut.lastIndexOf(' '), 1)).replace(/[,;:\s]+$/, '')}…`;
}

async function rasterize(svgPath, outPath) {
Expand Down
Loading