Repository navigation
Conversation
caption() split sentences on any '.', so 'JavaScript, .NET' ended the caption at 'JavaScript, .'. It also hard-cut a single long sentence mid-word and joined two sentences without a space. Split on punctuation followed by whitespace; break at a word with an ellipsis; join with a space. Found on a live send: the first dry run of morluto/rea showed the defect.
✅ Deploy Preview for explainmyrepo canceled.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caption helper split sentences on any '.', so '.NET' truncated the caption to 'JavaScript, .'; it also cut one long sentence mid-word and joined two sentences with no space. Found on the morluto/rea dry run. Tests: 80 pass across readme-pr, readme-enhance.station, outreach, outreach-cli, readme-ascii. No new test added for caption() (not exported); verified by dry-run output on a real repo.