Skip to content

test(plan): unmount the view so leftover {#if} patches cannot throw #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frahlg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(plan): unmount the view so leftover {#if} patches cannot throw #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 10 additions & 50 deletions src/views/Plan.svelte.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
*/

import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest'
import { render } from '@testing-library/svelte'
import { cleanup, render } from '@testing-library/svelte'
import Plan from './Plan.svelte'
import { SiteStore } from '$lib/state/site.svelte'
import { LoopbackCarrier } from '$lib/carrier/loopback'
Expand All @@ -27,6 +27,15 @@ function chart(): Element | null {
return document.querySelector('ftw-price-chart')
}

// destroy() the view. Emptying the document leaves $effects and asks
// running; a late {#if} patch then throws Comment is not defined, which
// is how CI went red with every test still green.
afterEach(() => {
cleanup()
vi.useRealTimers()
vi.restoreAllMocks()
})

describe('the Plan view, against the simulator', () => {
let fetched: ReturnType<typeof vi.spyOn>

Expand All @@ -35,11 +44,6 @@ describe('the Plan view, against the simulator', () => {
fetched = vi.spyOn(globalThis, 'fetch').mockRejectedValue(new Error('no origin'))
})

afterEach(() => {
document.body.replaceChildren()
vi.restoreAllMocks()
})

async function mount() {
const site = new SiteStore('test')
site.connect(new LoopbackCarrier(new SimBox({ now: () => MORNING }), { latencyMs: 0 }))
Expand Down Expand Up @@ -156,11 +160,6 @@ describe('a viewer on the Plan screen', () => {
vi.spyOn(globalThis, 'fetch').mockRejectedValue(new Error('no origin'))
})

afterEach(() => {
document.body.replaceChildren()
vi.restoreAllMocks()
})

it('cannot press a mode, and is told why in the right words', async () => {
// Not hidden: which mode the house runs in is a reading, and a viewer is
// entitled to it. What must not happen is a live button the box will
Expand Down Expand Up @@ -224,11 +223,6 @@ describe('a viewer on the Plan screen', () => {
})

describe('the Plan screen before the box has answered', () => {
afterEach(() => {
document.body.replaceChildren()
vi.restoreAllMocks()
})

it('says nothing about what the box supports', async () => {
// A cold start paints from cache with no carrier yet: `caps` is empty
// because nobody has asked, not because the box said so. Both sentences
Expand All @@ -248,12 +242,6 @@ describe('the Plan screen before the box has answered', () => {
})

describe('a price window as the day moves under it', () => {
afterEach(() => {
document.body.replaceChildren()
vi.useRealTimers()
vi.restoreAllMocks()
})

/** Real box, real wire, and a clock the test drives. */
async function drawn() {
vi.useFakeTimers()
Expand Down Expand Up @@ -338,12 +326,6 @@ describe('a price window as the day moves under it', () => {
describe('a plan the box could not answer', () => {
const rows = () => document.querySelectorAll('section.timeline li').length

afterEach(() => {
document.body.replaceChildren()
vi.useRealTimers()
vi.restoreAllMocks()
})

it('is asked for again on its own, without the session ever moving', async () => {
vi.useFakeTimers()
vi.setSystemTime(MORNING)
Expand Down Expand Up @@ -467,12 +449,6 @@ describe('a plan the box could not answer', () => {
describe('a plan and a price window the wire cut short', () => {
const rows = () => document.querySelectorAll('section.timeline li').length

afterEach(() => {
document.body.replaceChildren()
vi.useRealTimers()
vi.restoreAllMocks()
})

it('arrive on their own once the carrier is back', async () => {
vi.useFakeTimers()
vi.setSystemTime(MORNING)
Expand Down Expand Up @@ -530,12 +506,6 @@ describe('a plan and a price window the wire cut short', () => {
* clock can be moved without a box in the way.
*/
describe('when the Plan view asks for prices', () => {
afterEach(() => {
document.body.replaceChildren()
vi.useRealTimers()
vi.restoreAllMocks()
})

/** A store that believes it is streaming from a box that has prices. */
function streamingStore() {
const site = new SiteStore('test')
Expand Down Expand Up @@ -815,11 +785,6 @@ describe('when the Plan view asks for prices', () => {
describe('the notice under the price chart', () => {
const MIDNIGHT = new Date(2026, 6, 15, 0, 0, 0).getTime()

afterEach(() => {
document.body.replaceChildren()
vi.restoreAllMocks()
})

/** An hourly window over `hours`, skipping any hour in `missing`. */
function window(hours: number, missing: readonly number[] = []): Prices {
const slots = []
Expand Down Expand Up @@ -908,11 +873,6 @@ describe('the notice under the price chart', () => {
* card greying out on send read as the tap having done nothing.
*/
describe('switching how the home is run', () => {
afterEach(() => {
document.body.replaceChildren()
vi.restoreAllMocks()
})

function choice(label: string): HTMLButtonElement | undefined {
return [...document.querySelectorAll('button.choice')].find((b) =>
b.textContent?.includes(label)
Expand Down
Loading