Repository navigation
Conversation
Main verify failed with Comment is not defined in Plan.svelte after every
test had passed. The suite tore down by emptying document.body, which
leaves $effects and askWhenLive promises running; a late {#if} patch then
constructs a comment node against a jsdom that has already dropped Comment.
cleanup() from testing-library destroy()s the component, the same way the
other mounted views already do.
Co-authored-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ftw-webapp | 058d803 | Commit Preview URL Branch Preview URL |
Oct 23 2026, 02:34 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main
verifywent red on#101with every test still green:#101did not touch Plan. The suite tore down by emptyingdocument.body, which leaves$effectsandaskWhenLivepromises running. A late{#if}patch then constructs a comment node against a jsdom that has already droppedComment.This switches the Plan tests to
cleanup()from testing-library, whichdestroy()s the component — the same teardown the other mounted views already use.No product change. No changeset.