Conversation
ce6ea87 to
e9a9010
Compare
442c13d to
cdf9d9c
Compare
852706e to
4671c09
Compare
50aa563 to
978d2f2
Compare
4671c09 to
170d25d
Compare
|
@81reap Just a detail, but : could you please name your commits "fix" or "feat" only when they impact actual SQLPage users ? You can use "refactor" for commits that improve the architecture without user-visible changes. |
rust-toolchain.tomlrust-toolchain.toml
e6f4f69 to
381e1af
Compare
381e1af to
0d1a448
Compare
0d1a448 to
80b41b6
Compare
|
actions-rust-lang/setup-rust-toolchain sounds like a tiny personal project, are you sure it's reasonable? I'm not a huge fan of pinning the rust version independently in one more place. |
|
oh it didn't seem like a tiny project https://github.com/search?q=%22actions-rust-lang%2Fsetup-rust-toolchain%22&type=code and it does respect the toml so we would be only pinning Rust independently in one place it's also based off the existing action we use the existing action has an issue about this that's closed as completed but there is no reference to toml in the codebase https://github.com/search?q=repo%3Adtolnay%2Frust-toolchain+toml&type=code I am not aware of any offical Rust Github Action that would fit the needs we want here |
Before the Dockerfile pinned 1.95 but the CI steps would use the current stable version of Rust. Now they are all pinned to the same version via `rust-toolchain.toml`. This requires using `actions-rust-lang/setup-rust-toolchain` as it respects the toml file.
80b41b6 to
51d2b4b
Compare
Before the Dockerfile pinned 1.95 but the CI steps would use the current stable version of Rust.
Now they are all pinned to the same version via
rust-toolchain.toml. This requires usingactions-rust-lang/setup-rust-toolchainas it respects the toml file.Stack created with GitHub Stacks CLI • Give Feedback 💬