Skip to content

refactor(rust) :: pin toolchain with rust-toolchain.toml - #1487

Open
81reap wants to merge 1 commit into
mainfrom
81reap/rust-toolchain
Open

81reap wants to merge 1 commit into
mainfrom
81reap/rust-toolchain

Conversation

@81reap

@81reap 81reap commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

Before the Dockerfile pinned 1.95 but the CI steps would use the current stable version of Rust.

Now they are all pinned to the same version via rust-toolchain.toml. This requires using actions-rust-lang/setup-rust-toolchain as it respects the toml file.


Stack created with GitHub Stacks CLI • Give Feedback 💬

@81reap
81reap added this pull request to stack #1492 September 24, 2026 05:42
@81reap
81reap force-pushed the 81reap/rust-toolchain branch from ce6ea87 to e9a9010 Compare September 24, 2026 05:43
@81reap
81reap force-pushed the 81reap/test-scripts branch 2 times, most recently from 442c13d to cdf9d9c Compare September 24, 2026 13:23
@81reap
81reap force-pushed the 81reap/rust-toolchain branch 2 times, most recently from 852706e to 4671c09 Compare September 24, 2026 13:57
@81reap
81reap force-pushed the 81reap/test-scripts branch from 50aa563 to 978d2f2 Compare September 24, 2026 13:57
@81reap
81reap force-pushed the 81reap/rust-toolchain branch from 4671c09 to 170d25d Compare September 24, 2026 13:57
Base automatically changed from 81reap/test-scripts to main September 24, 2026 14:55
@lovasoa

lovasoa commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

@81reap Just a detail, but : could you please name your commits "fix" or "feat" only when they impact actual SQLPage users ? You can use "refactor" for commits that improve the architecture without user-visible changes.

@81reap 81reap changed the title feat(rust) :: pin toolchain with rust-toolchain.toml refactor(rust) :: pin toolchain with rust-toolchain.toml Sep 24, 2026
@81reap
81reap force-pushed the 81reap/rust-toolchain branch 3 times, most recently from e6f4f69 to 381e1af Compare September 24, 2026 21:50
@81reap
81reap removed this pull request from stack #1492 September 24, 2026 21:50
@81reap
81reap changed the base branch from main to 81reap/fix-hurl-race September 24, 2026 21:50
@81reap
81reap force-pushed the 81reap/rust-toolchain branch from 381e1af to 0d1a448 Compare September 24, 2026 22:00
@81reap
81reap changed the base branch from 81reap/fix-hurl-race to main September 24, 2026 22:06
@81reap
81reap added this pull request to stack #1497 September 25, 2026 04:19
@81reap
81reap force-pushed the 81reap/rust-toolchain branch from 0d1a448 to 80b41b6 Compare September 25, 2026 04:19
@81reap
81reap requested a review from lovasoa September 25, 2026 04:47
@lovasoa

lovasoa commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

actions-rust-lang/setup-rust-toolchain sounds like a tiny personal project, are you sure it's reasonable?

I'm not a huge fan of pinning the rust version independently in one more place.

@lovasoa
lovasoa removed this pull request from stack #1497 September 25, 2026 10:20
@81reap

81reap commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator Author

oh it didn't seem like a tiny project

https://github.com/search?q=%22actions-rust-lang%2Fsetup-rust-toolchain%22&type=code

and it does respect the toml so we would be only pinning Rust independently in one place

https://github.com/actions-rust-lang/setup-rust-toolchain/blob/c8ff772090ab9d00f7f7bd7b388f3c3032282e3b/action.yml#L205-L218

it's also based off the existing action we use

https://github.com/actions-rust-lang/setup-rust-toolchain/blob/c8ff772090ab9d00f7f7bd7b388f3c3032282e3b/README.md?plain=1#L9

the existing action has an issue about this that's closed as completed

dtolnay/rust-toolchain#116

but there is no reference to toml in the codebase

https://github.com/search?q=repo%3Adtolnay%2Frust-toolchain+toml&type=code

I am not aware of any offical Rust Github Action that would fit the needs we want here

Before the Dockerfile pinned 1.95 but the CI steps would use the current stable version of Rust.

Now they are all pinned to the same version via `rust-toolchain.toml`. This requires using `actions-rust-lang/setup-rust-toolchain` as it respects the toml file.
@81reap
81reap force-pushed the 81reap/rust-toolchain branch from 80b41b6 to 51d2b4b Compare September 25, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants