Skip to content

refactor(ci) :: fix flakey hurl test - #1496

Closed
81reap wants to merge 1 commit into
mainfrom
81reap/fix-hurl-race
Closed

81reap wants to merge 1 commit into
mainfrom
81reap/fix-hurl-race

Conversation

@81reap

@81reap 81reap commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

The HURL tests in the CI downloads sqlpage-linux-amd64-minimal-image but it is now a race condition as it does not wait for docker_build and could try pulling an image that doesn't yet exist.


Stack created with GitHub Stacks CLI • Give Feedback 💬

The HURL tests in the CI downloads `sqlpage-linux-amd64-minimal-image` but it is now a race condition as it does not wait for `docker_build` and could try pulling an image that doesn't yet exist.
@lovasoa

lovasoa commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

thanks for your quick reaction :) I already have a pr here #1495

@lovasoa lovasoa closed this Sep 24, 2026
@81reap

81reap commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

oh haha sorry didn't see that @lovasoa

I was gonna say as per #1487 (comment) I have labeled this a refactor but IMO it should be a fix. But seems like you also labled it a fix. I think it would be helpful to capture this nuance in CONTRIBUTING.md so that I can better align to how you define these categories.

@81reap
81reap deleted the 81reap/fix-hurl-race branch September 24, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants