Skip to content

Fix PHP 8.5 curl_close() deprecation and TypeError on failed curl_init() #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Buzka91 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PHP 8.5 curl_close() deprecation and TypeError on failed curl_init() #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Curl/HttpClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ private function prepareRequestHttpClient(RequestInterface $request)

if ($httpClient === false) {
throw NetworkException::withRequest(
'Cannot prepare HTTP client: ' . curl_error($httpClient),
'Cannot prepare HTTP client',
$request
);
}
Expand Down Expand Up @@ -103,6 +103,9 @@ private function execute(RequestInterface $request, $httpClient): ResponseInterf

private function closeHttpClient($httpClient)
{
curl_close($httpClient);
// curl_close() has no effect since PHP 8.0 and is deprecated since PHP 8.5
if (PHP_VERSION_ID < 80000) {
curl_close($httpClient);
}
}
}